Updating vnic type is not working

[Vasyl Saienko]

Contrail blocks updating VNIC type [0], however it is a legal use case when using Ironic (baremetal provisioner) [1] due to several reasons:

1. With mixed clouds user may not know if instance will be placed on KVM or baremetal server.
2. Nova always create a ports with 'normal' vnic type, but even if it can pick vnic type dynamically we still need to update it for case when user pre-created a port (see case 1)
3. Ironic updates vnic type when trigger port binding in Neutron [1]

[0] https://github.com/Juniper/contrail-controller/blob/e3a0a81/src/config/api-server/vnc_cfg_types.py#L1303

[1] https://github.com/openstack/ironic/blob/b5863eb6b1e61092d42d05ae9e18918b598eb406/ironic/drivers/modules/network/common.py#L255

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/35137
Submitter: Vasyl Saienko (<email address hidden>)

[Vasyl Saienko (vsaienko)]

related patch proposed https://review.opencontrail.org/#/c/35137

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/35137
Submitter: Vasyl Saienko (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/35137
Committed: http://github.com/Juniper/contrail-controller/commit/3ef7d84b3fdd3cae204931fb5e4c695b630f2a42
Submitter: Zuul (<email address hidden>)
Branch: master

commit 3ef7d84b3fdd3cae204931fb5e4c695b630f2a42
Author: Andrey Shestakov <email address hidden>
Date: Thu Aug 31 13:43:30 2017 +0300

Allow to update vnic_type when port is not bound

Updating vnic type is legal procedure, and is used by Ironic. This patch
allows to update vnic type when port is not bound (doesn't have
references to VM or Vrouter)

Closes-Bug: 1719268

Change-Id: Ic7b6a7232316c698b2f8521a9b3d46fb755d4e3d

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37162
Submitter: Vasyl Saienko (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37163
Submitter: Vasyl Saienko (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37164
Submitter: Vasyl Saienko (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37165
Submitter: Vasyl Saienko (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37166
Submitter: Vasyl Saienko (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37167
Submitter: Vasyl Saienko (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37162
Committed: http://github.com/Juniper/contrail-controller/commit/8d528ebca8be428280c3e51224bf2cb4d3f1bced
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 8d528ebca8be428280c3e51224bf2cb4d3f1bced
Author: Andrey Shestakov <email address hidden>
Date: Thu Aug 31 13:43:30 2017 +0300

Allow to update vnic_type when port is not bound

Updating vnic type is legal procedure, and is used by Ironic. This patch
allows to update vnic type when port is not bound (doesn't have
references to VM or Vrouter)

Closes-Bug: 1719268

Change-Id: Ic7b6a7232316c698b2f8521a9b3d46fb755d4e3d
(cherry picked from commit 3ef7d84b3fdd3cae204931fb5e4c695b630f2a42)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37167
Committed: http://github.com/Juniper/contrail-controller/commit/4264478e719811a8e6d58121f06ecff2c945515f
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 4264478e719811a8e6d58121f06ecff2c945515f
Author: Andrey Shestakov <email address hidden>
Date: Thu Aug 31 13:43:30 2017 +0300

Allow to update vnic_type when port is not bound

Updating vnic type is legal procedure, and is used by Ironic. This patch
allows to update vnic type when port is not bound (doesn't have
references to VM or Vrouter)

Closes-Bug: 1719268

Change-Id: Ic7b6a7232316c698b2f8521a9b3d46fb755d4e3d
(cherry picked from commit 3ef7d84b3fdd3cae204931fb5e4c695b630f2a42)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37163
Committed: http://github.com/Juniper/contrail-controller/commit/48626c1710e4e5262852f058b9eee17d40fe2440
Submitter: Zuul (<email address hidden>)
Branch: R3.1

commit 48626c1710e4e5262852f058b9eee17d40fe2440
Author: Andrey Shestakov <email address hidden>
Date: Thu Aug 31 13:43:30 2017 +0300

Allow to update vnic_type when port is not bound

Updating vnic type is legal procedure, and is used by Ironic. This patch
allows to update vnic type when port is not bound (doesn't have
references to VM or Vrouter)

Closes-Bug: 1719268

Change-Id: Ic7b6a7232316c698b2f8521a9b3d46fb755d4e3d
(cherry picked from commit 3ef7d84b3fdd3cae204931fb5e4c695b630f2a42)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37218
Submitter: Vasyl Saienko (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37164
Committed: http://github.com/Juniper/contrail-controller/commit/4536b18173b2457ccbd3782086352d9d482537d6
Submitter: Zuul (<email address hidden>)
Branch: R3.1.1.x

commit 4536b18173b2457ccbd3782086352d9d482537d6
Author: Andrey Shestakov <email address hidden>
Date: Thu Aug 31 13:43:30 2017 +0300

Allow to update vnic_type when port is not bound

Updating vnic type is legal procedure, and is used by Ironic. This patch
allows to update vnic type when port is not bound (doesn't have
references to VM or Vrouter)

Closes-Bug: 1719268

Change-Id: Ic7b6a7232316c698b2f8521a9b3d46fb755d4e3d
(cherry picked from commit 3ef7d84b3fdd3cae204931fb5e4c695b630f2a42)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37165
Committed: http://github.com/Juniper/contrail-controller/commit/f62859851e635af5d1124e8f2f752d38cdc525ef
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit f62859851e635af5d1124e8f2f752d38cdc525ef
Author: Andrey Shestakov <email address hidden>
Date: Thu Aug 31 13:43:30 2017 +0300

Allow to update vnic_type when port is not bound

Updating vnic type is legal procedure, and is used by Ironic. This patch
allows to update vnic type when port is not bound (doesn't have
references to VM or Vrouter)

Closes-Bug: 1719268

Change-Id: Ic7b6a7232316c698b2f8521a9b3d46fb755d4e3d
(cherry picked from commit 3ef7d84b3fdd3cae204931fb5e4c695b630f2a42)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37166
Committed: http://github.com/Juniper/contrail-controller/commit/84e20ac021091738c3eb213745105f47c3d5616a
Submitter: Zuul (<email address hidden>)
Branch: R3.2.3.x

commit 84e20ac021091738c3eb213745105f47c3d5616a
Author: Andrey Shestakov <email address hidden>
Date: Thu Aug 31 13:43:30 2017 +0300

Allow to update vnic_type when port is not bound

Updating vnic type is legal procedure, and is used by Ironic. This patch
allows to update vnic type when port is not bound (doesn't have
references to VM or Vrouter)

Closes-Bug: 1719268

Change-Id: Ic7b6a7232316c698b2f8521a9b3d46fb755d4e3d
(cherry picked from commit 3ef7d84b3fdd3cae204931fb5e4c695b630f2a42)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37218
Submitter: Vasyl Saienko (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37218
Committed: http://github.com/Juniper/contrail-controller/commit/fa6ff9987e618f99ab4c5e73044443856eb41c26
Submitter: Zuul (<email address hidden>)
Branch: master

commit fa6ff9987e618f99ab4c5e73044443856eb41c26
Author: Vasyl Saienko <email address hidden>
Date: Mon Nov 6 19:49:55 2017 +0200

Update is_port_bound condition

There is a difference between baremetal and non baremetal ports.

Baremetal ports are considered as bound only when:
1. binding:profile contains local_link_information which describes
physical connection of port (switch, port, etc)
2. binding:host_id is set.

Non baremetal ports may be considered as bound when:
1. Port is linked to VM or Vrouter

This patch updates is_port_bound logic accordingly.

Closes-Bug: 1719268

Change-Id: Id5452b1e24f83a2a3140c21e51fd42f5454ef328