Change default compaction strategy for analytics table

Bug #1648252 reported by Megh Bhatt on 2016-12-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
High
Megh Bhatt
R3.0.2.x
Fix Committed
High
Megh Bhatt
R3.0.3.x
Fix Committed
High
Megh Bhatt
R3.1
Fix Committed
High
Megh Bhatt
R3.1.1.x
In Progress
High
Megh Bhatt
R3.2
Fix Released
High
Megh Bhatt
Trunk
Fix Committed
High
Megh Bhatt

Bug Description

Change default compaction strategy for analytics table

1. Flow tables - DateTieredCompactionStrategy
2. Other tables - SizeTieredCompactionStrategy

We have found that LeveledCompactionStrategy causes lot of load specially when running on HDD.

Review in progress for https://review.opencontrail.org/26987
Submitter: Megh Bhatt (<email address hidden>)

Review in progress for https://review.opencontrail.org/26995
Submitter: Megh Bhatt (<email address hidden>)

Review in progress for https://review.opencontrail.org/26996
Submitter: Megh Bhatt (<email address hidden>)

Review in progress for https://review.opencontrail.org/26997
Submitter: Megh Bhatt (<email address hidden>)

Reviewed: https://review.opencontrail.org/26987
Committed: http://github.org/Juniper/contrail-controller/commit/da5161c595c483c0a90022f09d61e7f7411a2612
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit da5161c595c483c0a90022f09d61e7f7411a2612
Author: Megh Bhatt <email address hidden>
Date: Wed Dec 7 15:23:45 2016 -0800

Change default compaction strategy and add option for flow tables

Change default compaction strategy to SizeTieredCompactionStrategy

Add CASSANDRA.flow_tables.compaction_strategy and default to
DateTieredCompactionStrategy

Change-Id: I4742dceaece999b31e065e004188e30919b461c3
Closes-Bug: #1648252

Reviewed: https://review.opencontrail.org/26996
Committed: http://github.org/Juniper/contrail-controller/commit/2ccc2bb772bb93296fddde21e9d9c7c7624142a5
Submitter: Zuul (<email address hidden>)
Branch: R3.0.2.x

commit 2ccc2bb772bb93296fddde21e9d9c7c7624142a5
Author: Megh Bhatt <email address hidden>
Date: Wed Dec 7 15:23:45 2016 -0800

Change default compaction strategy and add option for flow tables

Change default compaction strategy to SizeTieredCompactionStrategy

Add CASSANDRA.flow_tables.compaction_strategy and default to
DateTieredCompactionStrategy

Closes-Bug: #1648252

Conflicts:
 src/analytics/db_handler.cc
 src/analytics/db_handler.h
 src/analytics/main.cc
 src/analytics/test/db_handler_mock.h
 src/analytics/viz_collector.cc
 src/analytics/viz_collector.h

Change-Id: I4742dceaece999b31e065e004188e30919b461c3

Reviewed: https://review.opencontrail.org/26997
Committed: http://github.org/Juniper/contrail-controller/commit/77e734f009d9103992360be7043119182d2b2513
Submitter: Zuul (<email address hidden>)
Branch: R3.0.3.x

commit 77e734f009d9103992360be7043119182d2b2513
Author: Megh Bhatt <email address hidden>
Date: Wed Dec 7 15:23:45 2016 -0800

Change default compaction strategy and add option for flow tables

Change default compaction strategy to SizeTieredCompactionStrategy

Add CASSANDRA.flow_tables.compaction_strategy and default to
DateTieredCompactionStrategy

Closes-Bug: #1648252

Conflicts:
 src/analytics/db_handler.cc
 src/analytics/db_handler.h
 src/analytics/main.cc
 src/analytics/test/db_handler_mock.h
 src/analytics/viz_collector.cc
 src/analytics/viz_collector.h

Change-Id: I4742dceaece999b31e065e004188e30919b461c3

Review in progress for https://review.opencontrail.org/27079
Submitter: Megh Bhatt (<email address hidden>)

Reviewed: https://review.opencontrail.org/26995
Committed: http://github.org/Juniper/contrail-controller/commit/c5328c5fe970da22ed14e6d2664f38d83741d67d
Submitter: Zuul (<email address hidden>)
Branch: R3.0

commit c5328c5fe970da22ed14e6d2664f38d83741d67d
Author: Megh Bhatt <email address hidden>
Date: Wed Dec 7 15:23:45 2016 -0800

Change default compaction strategy and add option for flow tables

Change default compaction strategy to SizeTieredCompactionStrategy

Add CASSANDRA.flow_tables.compaction_strategy and default to
DateTieredCompactionStrategy

Closes-Bug: #1648252

Conflicts:
 src/analytics/db_handler.cc
 src/analytics/db_handler.h
 src/analytics/main.cc
 src/analytics/test/db_handler_mock.h
 src/analytics/viz_collector.cc
 src/analytics/viz_collector.h

Change-Id: I4742dceaece999b31e065e004188e30919b461c3

Reviewed: https://review.opencontrail.org/27079
Committed: http://github.org/Juniper/contrail-controller/commit/da793c765d5f3f2d58214b9cd58db63e1ea610d5
Submitter: Zuul (<email address hidden>)
Branch: master

commit da793c765d5f3f2d58214b9cd58db63e1ea610d5
Author: Megh Bhatt <email address hidden>
Date: Wed Dec 7 15:23:45 2016 -0800

Change default compaction strategy and add option for flow tables

Change default compaction strategy to SizeTieredCompactionStrategy

Add CASSANDRA.flow_tables.compaction_strategy and default to
DateTieredCompactionStrategy

Reenable options_test

Cleanup code in protobuf_collector

Closes-Bug: #1648252

Conflicts:
 src/analytics/test/db_handler_mock.h

Change-Id: I4742dceaece999b31e065e004188e30919b461c3

Review in progress for https://review.opencontrail.org/27570
Submitter: Raj Reddy (<email address hidden>)

Reviewed: https://review.opencontrail.org/27570
Committed: http://github.org/Juniper/contrail-controller/commit/5c64ff7409b5dd58a06f89f22ba8021910e330a6
Submitter: Zuul (<email address hidden>)
Branch: R3.1

commit 5c64ff7409b5dd58a06f89f22ba8021910e330a6
Author: Megh Bhatt <email address hidden>
Date: Wed Dec 7 15:23:45 2016 -0800

Change default compaction strategy and add option for flow tables

Change default compaction strategy to SizeTieredCompactionStrategy

Add CASSANDRA.flow_tables.compaction_strategy and default to
DateTieredCompactionStrategy

Change-Id: I4742dceaece999b31e065e004188e30919b461c3
Closes-Bug: #1648252
(cherry picked from commit da5161c595c483c0a90022f09d61e7f7411a2612)

Raj Reddy (rajreddy) on 2016-12-29
information type: Proprietary → Public
Mladen Maric (mmaric) wrote :

The compaction strategy DateTieredCompactionStrategy precludes using read repair, because of the way timestamps are checked for DTCS compaction.
In this case, you must set read_repair_chance to zero. For other compaction strategies, read repair should be enabled with a read_repair_chance value of 0.2 being typical.

Review in progress for https://review.opencontrail.org/29482
Submitter: Petr Jedin? (<email address hidden>)

Reviewed: https://review.opencontrail.org/29482
Committed: http://github.org/Juniper/contrail-controller/commit/832f870f0b14f03672b88746c83199f0ba08c788
Submitter: Zuul (<email address hidden>)
Branch: R3.1.1.x

commit 832f870f0b14f03672b88746c83199f0ba08c788
Author: Megh Bhatt <email address hidden>
Date: Wed Dec 7 15:23:45 2016 -0800

Change default compaction strategy and add option for flow tables

Change default compaction strategy to SizeTieredCompactionStrategy

Add CASSANDRA.flow_tables.compaction_strategy and default to
DateTieredCompactionStrategy

(cherry-pick da5161c595c483c0a90022f09d61e7f7411a2612)

Change-Id: I4742dceaece999b31e065e004188e30919b461c3
Related-Bug: #1648252
Closes-Bug: #1671625

Mykola Yakovliev (vegasq) wrote :

By mistake i marked it as released (not sure though why i have right to do it). Can you please move it to Fix Committed?

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers