vRouter: Some routes remain in the mtrie even after deletion

[Anand H. Krishnan]

It has been observed that if the less specific route is deleted first and then all the more specific routes, the less specific route doesn't go away. For e.g.: if 1.1.1.0/24 is deleted first and later 1.1.1.1/32 in a table where there are no other routes, 1.1.1.0/24 remains in the table.

When we delete a non leaf node, if it is a bucket we do not update the prefix length, flags and label values. If these values do not match with those of other nodes in the same bucket, then the bucket will remain forever.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18877
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18877
Committed: http://github.org/Juniper/contrail-vrouter/commit/ff52886c9b7e3939c7580c33480cbd8558167fe2
Submitter: Zuul
Branch: R2.21.x

commit ff52886c9b7e3939c7580c33480cbd8558167fe2
Author: Anand H. Krishnan <email address hidden>
Date: Wed Mar 30 14:23:14 2016 +0530

Update the less specific route node with requested values

It has been observed that if the less specific route is deleted first
and then all the more specific routes, the less specific route doesn't
go away. For e.g.: if 1.1.1.0/24 is deleted first and later 1.1.1.1/32
in a table where there are no other routes, 1.1.1.0/24 remains in the
table.

When we delete a non leaf node, if it is a bucket we do not update the
prefix length, flags and label values. If these values do not match with
those of other nodes in the same bucket, then the bucket will remain
forever. Hence, update the node with the values in the request before
traversing the tree down.

Change-Id: I71778a83093a04c462b40e6c7e05b1d993f3373e
Closes-BUG: #1563734

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18936
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18937
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18938
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18939
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18937
Committed: http://github.org/Juniper/contrail-vrouter/commit/a1953961a2ff088d71937e40c912768c6abbfbf4
Submitter: Zuul
Branch: R2.22.x

commit a1953961a2ff088d71937e40c912768c6abbfbf4
Author: Anand H. Krishnan <email address hidden>
Date: Wed Mar 30 14:23:14 2016 +0530

Update the less specific route node with requested values

It has been observed that if the less specific route is deleted first
and then all the more specific routes, the less specific route doesn't
go away. For e.g.: if 1.1.1.0/24 is deleted first and later 1.1.1.1/32
in a table where there are no other routes, 1.1.1.0/24 remains in the
table.

When we delete a non leaf node, if it is a bucket we do not update the
prefix length, flags and label values. If these values do not match with
those of other nodes in the same bucket, then the bucket will remain
forever. Hence, update the node with the values in the request before
traversing the tree down.

Change-Id: I71778a83093a04c462b40e6c7e05b1d993f3373e
Closes-BUG: #1563734

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18938
Committed: http://github.org/Juniper/contrail-vrouter/commit/89ed9490f663815f955c4f031224ab1eb6fbff4e
Submitter: Zuul
Branch: R2.20

commit 89ed9490f663815f955c4f031224ab1eb6fbff4e
Author: Anand H. Krishnan <email address hidden>
Date: Wed Mar 30 14:23:14 2016 +0530

Update the less specific route node with requested values

It has been observed that if the less specific route is deleted first
and then all the more specific routes, the less specific route doesn't
go away. For e.g.: if 1.1.1.0/24 is deleted first and later 1.1.1.1/32
in a table where there are no other routes, 1.1.1.0/24 remains in the
table.

When we delete a non leaf node, if it is a bucket we do not update the
prefix length, flags and label values. If these values do not match with
those of other nodes in the same bucket, then the bucket will remain
forever. Hence, update the node with the values in the request before
traversing the tree down.

Change-Id: I71778a83093a04c462b40e6c7e05b1d993f3373e
Closes-BUG: #1563734

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18936
Committed: http://github.org/Juniper/contrail-vrouter/commit/a0a68110f846a53e2bd0d679251739cce2e3646e
Submitter: Zuul
Branch: master

commit a0a68110f846a53e2bd0d679251739cce2e3646e
Author: Anand H. Krishnan <email address hidden>
Date: Wed Mar 30 14:23:14 2016 +0530

Update the less specific route node with requested values

It has been observed that if the less specific route is deleted first
and then all the more specific routes, the less specific route doesn't
go away. For e.g.: if 1.1.1.0/24 is deleted first and later 1.1.1.1/32
in a table where there are no other routes, 1.1.1.0/24 remains in the
table.

When we delete a non leaf node, if it is a bucket we do not update the
prefix length, flags and label values. If these values do not match with
those of other nodes in the same bucket, then the bucket will remain
forever. Hence, update the node with the values in the request before
traversing the tree down.

Change-Id: I71778a83093a04c462b40e6c7e05b1d993f3373e
Closes-BUG: #1563734

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18939
Committed: http://github.org/Juniper/contrail-vrouter/commit/ec6e924575769171fc86f7784f72cd88e5ae9bf6
Submitter: Zuul
Branch: R3.0

commit ec6e924575769171fc86f7784f72cd88e5ae9bf6
Author: Anand H. Krishnan <email address hidden>
Date: Wed Mar 30 14:23:14 2016 +0530

Update the less specific route node with requested values

It has been observed that if the less specific route is deleted first
and then all the more specific routes, the less specific route doesn't
go away. For e.g.: if 1.1.1.0/24 is deleted first and later 1.1.1.1/32
in a table where there are no other routes, 1.1.1.0/24 remains in the
table.

When we delete a non leaf node, if it is a bucket we do not update the
prefix length, flags and label values. If these values do not match with
those of other nodes in the same bucket, then the bucket will remain
forever. Hence, update the node with the values in the request before
traversing the tree down.

Change-Id: I71778a83093a04c462b40e6c7e05b1d993f3373e
Closes-BUG: #1563734