heat stack update to scale out service instance fails

[Vinoth Kannan Ganapathy]

Created a service chain with single instance using HOT, with the help of a template file.
Modified the scale out parameter of the template file, to have more instance and updated the stack and the update failed with

TypeError: object of type 'NoneType' has no len()

root@a5d01e09-1:~/heat_test/templates# heat stack-update -e service_chain_existing_network.env -f service_chain_exising_network.yaml 10548f89-427c-484c-bd65-1b57290277a6
+--------------------------------------+-------------------+--------------------+----------------------+
| id | stack_name | stack_status | creation_time |
+--------------------------------------+-------------------+--------------------+----------------------+
| c7c365c4-9b20-4668-ad43-4f6ff77164fe | IPAM | CREATE_COMPLETE | 2016-05-02T18:41:11Z |
| 9247c088-d747-44eb-a857-aee2868172ce | LEFT_VN_CREATE | CREATE_COMPLETE | 2016-05-02T18:57:41Z |
| d027cbd1-ac03-4ec6-be12-0e2871d99723 | RIGHT_VN_CREATE | CREATE_COMPLETE | 2016-05-02T18:58:06Z |
| 5fb46a23-c05d-42ab-9696-3ce897bd41cf | LEFT_SNET_CREATE | CREATE_COMPLETE | 2016-05-02T18:58:44Z |
| 03f1a680-76bf-45ff-bbd6-5a5a7d1e6325 | RIGHT_SNET_CREATE | CREATE_COMPLETE | 2016-05-02T18:59:08Z |
| a43acc19-bd84-4b7a-b94e-f4c0a37e9745 | SVC_TMPLT_CREATE | CREATE_COMPLETE | 2016-05-02T20:53:59Z |
| 10548f89-427c-484c-bd65-1b57290277a6 | SVC_CHAIN | UPDATE_IN_PROGRESS | 2016-05-03T21:09:37Z |
+--------------------------------------+-------------------+--------------------+----------------------+
root@a5d01e09-1:~/heat_test/templates#
root@a5d01e09-1:~/heat_test/templates# heat stack-list
+--------------------------------------+-------------------+-----------------+----------------------+
| id | stack_name | stack_status | creation_time |
+--------------------------------------+-------------------+-----------------+----------------------+
| c7c365c4-9b20-4668-ad43-4f6ff77164fe | IPAM | CREATE_COMPLETE | 2016-05-02T18:41:11Z |
| 9247c088-d747-44eb-a857-aee2868172ce | LEFT_VN_CREATE | CREATE_COMPLETE | 2016-05-02T18:57:41Z |
| d027cbd1-ac03-4ec6-be12-0e2871d99723 | RIGHT_VN_CREATE | CREATE_COMPLETE | 2016-05-02T18:58:06Z |
| 5fb46a23-c05d-42ab-9696-3ce897bd41cf | LEFT_SNET_CREATE | CREATE_COMPLETE | 2016-05-02T18:58:44Z |
| 03f1a680-76bf-45ff-bbd6-5a5a7d1e6325 | RIGHT_SNET_CREATE | CREATE_COMPLETE | 2016-05-02T18:59:08Z |
| a43acc19-bd84-4b7a-b94e-f4c0a37e9745 | SVC_TMPLT_CREATE | CREATE_COMPLETE | 2016-05-02T20:53:59Z |
| 10548f89-427c-484c-bd65-1b57290277a6 | SVC_CHAIN | UPDATE_FAILED | 2016-05-03T21:09:37Z |
+--------------------------------------+-------------------+-----------------+----------------------+

| outputs | [ |
| | { |
| | "output_value": 1, |
| | "description": "Number of active service VMs", |
| | "output_key": "num_active_service_instance_vms" |
| | }, |
| | { |
| | "output_value": [ |
| | { |
| | "status": "ACTIVE", |
| | "vm_id": "836cc5db-8689-4523-a580-c4879cc63280", |
| | "name": "contrail_si001" |
| | } |
| | ], |
| | "description": "List of service VMs", |
| | "output_key": "service_instance_vms" |
| | }, |
| | { |
| | "output_value": "default-domain:admin:contrail_si", |
| | "description": "FQ name of the service template", |
| | "output_key": "service_instance_fq_name" |
| | } |
| | ] |
| parameters | { |
| | "direction": "<>", |
| | "end_dst_ports": "-1", |
| | "OS::stack_id": "10548f89-427c-484c-bd65-1b57290277a6", |
| | "OS::stack_name": "SVC_CHAIN", |
| | "start_src_ports": "-1", |
| | "end_src_ports": "-1", |
| | "private_net_2_name": "default-domain:admin:RIGHT_VN", |
| | "private_instance_name": "contrail_si", |
| | "policy_name": "contrail_policy", |
| | "private_template": "default-domain:contrail_svc_temp1", |
| | "start_dst_ports": "-1", |
| | "private_availability_zone": "", |
| | "private_net_1_name": "default-domain:admin:LEFT_VN" |
| | } |
| parent | None |
| stack_name | SVC_CHAIN |
| stack_owner | admin |
| stack_status | UPDATE_FAILED |
| stack_status_reason | TypeError: object of type 'NoneType' has no len() |

[Praneet Bachheti (praneetb)]

Hi Vinoth,
  Tried it in R2.23-129 .. it works for me.

Can you please upload the heat template for ServiceTemplate.

[Vinoth Kannan Ganapathy (vganapathy)]

identified the issue, Praneet provided the temporary fix, waiting for the commit

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/20208
Submitter: Praneet Bachheti (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/20208
Committed: http://github.org/Juniper/contrail-heat/commit/520e834076991dfb37b27906fefa4b3b18b721f4
Submitter: Zuul
Branch: R2.22.x

commit 520e834076991dfb37b27906fefa4b3b18b721f4
Author: Praneet Bachheti <email address hidden>
Date: Fri May 13 12:28:23 2016 -0700

Fix stack-update for service_instance
use interface list from the service instance properties.

Change-Id: Ibb0c1f0d1864302c946719faf663f01fe3cd2b56
Closes-bug: 1577946