duplicate, incomplete ToR config causing Tor-agent connection to be down

[Vedamurthy Joshi]

R2.20 Build 108 Ubuntu 14.04 Juno

On this multi-node setup, The tor-agents were not up.
Hari and Ashok analyzed that it was due to the order of configs got for the ToR.
It seems initially, the ToR config was got without the ToR name and got an update (with the name) later.
The later update caused a second tor-config to be created instead of updating the existing one (See attachment)

Gcore will be in http://10.204.216.50/Docs/bugs/#

root@nodek3:~# contrail-status
== Contrail vRouter ==
supervisor-vrouter: active
contrail-tor-agent-1 initializing (ToR, ToR:bng-contrail-qfx51-1 connection down Number of connections:8, Expected: 7)
contrail-tor-agent-2 initializing (ToR connection down)
contrail-vrouter-agent active
contrail-vrouter-nodemgr active

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/15335
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/15335
Committed: http://github.org/Juniper/contrail-controller/commit/d0326c285844e2d9504e4a8f26c4e95b6f01f2da
Submitter: Zuul
Branch: R2.20

commit d0326c285844e2d9504e4a8f26c4e95b6f01f2da
Author: Hari <email address hidden>
Date: Mon Nov 23 12:02:06 2015 +0530

Ignore physical device notification when device name is not present.

When entry comes with empty name, state is being added in the notification
handler and further updates are ignored. Change this to not add state when
name is not available.

Change-Id: I4c5a668e35d1a2143dc61a63051a1e816f3cf085
closes-bug: 1518843

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/15580
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/15580
Committed: http://github.org/Juniper/contrail-controller/commit/7f796b1dcb0b89c713a0256559abadbd4f2c1020
Submitter: Zuul
Branch: master

commit 7f796b1dcb0b89c713a0256559abadbd4f2c1020
Author: Hari <email address hidden>
Date: Mon Nov 23 12:02:06 2015 +0530

Ignore physical device notification when device name is not present.

When entry comes with empty name, state is being added in the notification
handler and further updates are ignored. Change this to not add state when
name is not available.

Change-Id: I4c5a668e35d1a2143dc61a63051a1e816f3cf085
closes-bug: 1518843
(cherry picked from commit d0326c285844e2d9504e4a8f26c4e95b6f01f2da)