[2.20-Build 64] vrf_name in "Monitor >Infrastructure >Virtual Routers" shows "--ERROR--"

[Daisuke Nakajima]

if name of VMI uses '_' in its name, vrf_name in "Monitor >Infrastructure >Virtual Routers" shows "--ERROR--".

 {
  index: "1",
  name: "testvni_01",
  uuid: "00000001-9999-0000-0001-000000000002",
  vrf_name: "--ERROR--",
  active: "L3 Inactive < vrf-null no-ip-addr >",
  dhcp_service: "Enable",
  dns_service: "Enable",
  type: "vport",
  label: "-1",
  vn_name: "default-domain:demo:testvn01",
  vm_uuid: "",
  vm_name: "",
  ip_addr: "0.0.0.0",
  mac_addr: "30:00:01:01:00:01",
  policy: "Enable",
  fip_list: {
    list: ""
  },
  mdata_ip_addr: "0.0.0.0",
  service_vlan_list: {
    list: ""
  },
  os_ifindex: "-1",
  fabric_port: "NotFabricPort",
  alloc_linklocal_ip: "LL-Enable",
  analyzer_name: "",
  config_name: "default-domain:demo:testvni_01",
  sg_uuid_list: {
    list: {
      VmIntfSgUuid: {
        sg_uuid: "a019c144-12a5-496e-9508-b13b5151bd5f"
      }
    }
  },
  l2_label: "-1",
  vxlan_id: "11",
  static_route_list: {
    list: ""
  },
  l2_active: "L2 Inactive < vrf-null >",
  vm_project_uuid: "00000000-0000-0000-0000-000000000000",
  admin_state: "Enabled",
  flow_key_idx: "0",
  allowed_address_pair_list: {
    list: ""
  },
  ip6_addr: "::",
  ip6_active: "Inactive",
  local_preference: "0",
  tx_vlan_id: "-1",
  rx_vlan_id: "-1",
  parent_interface: "",
  sub_type: "TOR",
  vmi_type: "Baremetal",
  transport: "Unknown",
  logical_interface_uuid: "f10ac01c-abe4-4e99-a6d7-77ca69ef5582",
  flood_unknown_unicast: "true",
  dispName: "testvni_01",
  disp_fip_list: "None"
}

JSON
{
    "virtual-machine-interface": {
        "display_name": "testvni_01",
        "fq_name": [
            "default-domain",
            "demo",
            "testvni_01"
        ],
        "href": "http://172.27.113.209:8082/virtual-machine-interface/00000001-9999-0000-0001-000000000002",
        "id_perms": {
            "created": "2015-07-23T02:15:31.887081",
            "creator": null,
            "description": null,
            "enable": true,
            "last_modified": "2015-07-23T02:15:31.887081",
            "permissions": {
                "group": "admin",
                "group_access": 7,
                "other_access": 7,
                "owner": "admin",
                "owner_access": 7
            },
            "user_visible": true,
            "uuid": {
                "uuid_lslong": 281474976710658,
                "uuid_mslong": 6871908352
            }
        },
        "logical_interface_back_refs": [
            {
                "attr": null,
                "href": "http://172.27.113.209:8082/logical-interface/f10ac01c-abe4-4e99-a6d7-77ca69ef5582",
                "to": [
                    "default-global-system-config",
                    "fuda",
                    "ge-0/0/0",
                    "ge-0/0/0.10"
                ],
                "uuid": "f10ac01c-abe4-4e99-a6d7-77ca69ef5582"
            }
        ],
        "name": "testvni_01",
        "parent_href": "http://172.27.113.209:8082/project/c05418b9-2f32-47f3-a085-a004dae65e49",
        "parent_type": "project",
        "parent_uuid": "c05418b9-2f32-47f3-a085-a004dae65e49",
        "security_group_refs": [
            {
                "attr": null,
                "href": "http://172.27.113.209:8082/security-group/a019c144-12a5-496e-9508-b13b5151bd5f",
                "to": [
                    "default-domain",
                    "demo",
                    "default"
                ],
                "uuid": "a019c144-12a5-496e-9508-b13b5151bd5f"
            }
        ],
        "uuid": "00000001-9999-0000-0001-000000000002",
        "virtual_machine_interface_device_owner": "",
        "virtual_machine_interface_mac_addresses": {
            "mac_address": [
                "30:00:01:01:00:01"
            ]
        },
        "virtual_network_refs": [
            {
                "attr": null,
                "href": "http://172.27.113.209:8082/virtual-network/00000000-9999-0000-0001-000000000001",
                "to": [
                    "default-domain",
                    "demo",
                    "testvn01"
                ],
                "uuid": "00000000-9999-0000-0001-000000000001"
            }
        ]
    }
}

[Daisuke Nakajima (dnakajima)]

This issue was occurred after following procedure as well.
1) Create virtual-machine-interface
2) Create logical-interface
3) Delete above VMI and logical-interface
4) Create same virtual-machine-interface as same as last fq-name/UUID
5) Create logical-interface as same as last fq-name/UUID

after that vrf_name shows "--ERROR--"

[Manoj (manojgn)]

When we add a VMI - Delete it and Create again with the same name (same uuid no required) the Routing Instance is created and further if we link a Logical Interface to this VMI the interface status is shown as down and the VRF show "--ERROR'--"

[Manoj (manojgn)]

schema generator doesn't create/link the routing instance when port with same name is created again.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/13767
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/13767
Committed: http://github.org/Juniper/contrail-controller/commit/f78e7047e619abf4fdc2acae626b6ff6f5e24d3c
Submitter: Zuul
Branch: R2.20

commit f78e7047e619abf4fdc2acae626b6ff6f5e24d3c
Author: Sachin Bansal <email address hidden>
Date: Fri Sep 11 13:32:50 2015 -0700

Handle deletion of vmi correctly in schema transformer

Currently, schema transformer only deletes VMi from its internal database when
link to VM goes away. This causes problems for VMIs which are not attached to
any VMI (e.g. VMI created for TOR). As a result, when another VMI with same name
is created, schema transformer does not link it to the default RI. With this
change, if the link to its parent goes away, we will delete the VMI locally.

Change-Id: Ic17a31f67a3ca7ee6d7c136bf1d348224f561646
Closes-Bug: 1477371

[Sachin Bansal (sbansal)]

In R2.22 or later, fixed with: http://github.org/Juniper/contrail-controller/commit/d760565d5cae95cff09071f2c1a0a55314f8687e

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14212
Submitter: Hampapur Ajay (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14212
Committed: http://github.org/Juniper/contrail-controller/commit/3b5d16d137a4f37fd5bf70864a31f1a2612697f3
Submitter: Zuul
Branch: R2.20.x

commit 3b5d16d137a4f37fd5bf70864a31f1a2612697f3
Author: Sachin Bansal <email address hidden>
Date: Fri Sep 11 13:32:50 2015 -0700

Handle deletion of vmi correctly in schema transformer

Currently, schema transformer only deletes VMi from its internal database when
link to VM goes away. This causes problems for VMIs which are not attached to
any VMI (e.g. VMI created for TOR). As a result, when another VMI with same name
is created, schema transformer does not link it to the default RI. With this
change, if the link to its parent goes away, we will delete the VMI locally.

Change-Id: Ic17a31f67a3ca7ee6d7c136bf1d348224f561646
Closes-Bug: 1477371
(cherry picked from commit f78e7047e619abf4fdc2acae626b6ff6f5e24d3c)