Juniper Openstack

Vrouter module exit leads to crash, while cleaninup the memory

Series r2.20
Bug #1475558

Bug #1475558 reported by Divakar Dharanalakota on 2015-07-17

This bug affects 1 person

	Status	Importance	Assigned to
Juniper Openstack	Status tracked in Trunk
R2.0	Fix Committed	Medium	Divakar Dharanalakota
R2.20	Fix Committed	Medium	Divakar Dharanalakota
Trunk	Fix Committed	Medium	Divakar Dharanalakota

Bug Description

If module init fails for some reason, the graceful cleaup of vrouter is leading to crash while cleaning the stats memory. Even if the stats memory is not allocated, we are attempting to access it, leading to the crash.

Tags:

Divakar Dharanalakota (ddivakar) on 2015-07-17

Changed in juniperopenstack:
milestone:	none → r2.21
milestone:	r2.21 → none

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-07-17: [Review update] master

Review in progress for https://review.opencontrail.org/12466
Submitter: Divakar Dharanalakota (<email address hidden>)

Revision history for this message

Divakar Dharanalakota (ddivakar) wrote on 2015-07-17:

sanity_crash.jpg Edit (101.3 KiB, image/jpeg)

screenshot of crash

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-07-17: A change has been merged

Reviewed: https://review.opencontrail.org/12466
Committed: http://github.org/Juniper/contrail-vrouter/commit/8ee98bf87db8a47d3837b9d289f18b91b6dd9a30
Submitter: Zuul
Branch: master

commit 8ee98bf87db8a47d3837b9d289f18b91b6dd9a30
Author: Divakar <email address hidden>
Date: Fri Jul 17 02:28:08 2015 -0700

Null check before freeing stats memory

While doing the module cleanup, incase of module init, the stats
memory needs to be cleaned up only it is already allocated. Accessing it
without validating it is allocated or not, leads to crash.
closes-bug: #1475558

Change-Id: Iaf0d67014174506d51bd9a46671e64d463d0db71

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-08-03: [Review update] R2.0

Review in progress for https://review.opencontrail.org/12800
Submitter: Divakar Dharanalakota (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-08-03: [Review update] R2.20

Review in progress for https://review.opencontrail.org/12801
Submitter: Divakar Dharanalakota (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-08-10: A change has been merged

Reviewed: https://review.opencontrail.org/12801
Committed: http://github.org/Juniper/contrail-vrouter/commit/0750d4139fa906b0b0dc1fce696f3b6dfaa1ca6f
Submitter: Zuul
Branch: R2.20

commit 0750d4139fa906b0b0dc1fce696f3b6dfaa1ca6f
Author: Divakar <email address hidden>
Date: Fri Jul 17 02:28:08 2015 -0700

Null check before freeing stats memory

Change-Id: Iaf0d67014174506d51bd9a46671e64d463d0db71

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-08-13:

#10

Reviewed: https://review.opencontrail.org/12800
Committed: http://github.org/Juniper/contrail-vrouter/commit/3749d1985d2d09caa0af8b535969433e35e3c1ea
Submitter: Zuul
Branch: R2.0

commit 3749d1985d2d09caa0af8b535969433e35e3c1ea
Author: Divakar <email address hidden>
Date: Fri Jul 17 02:28:08 2015 -0700

Null check before freeing stats memory

While doing the module cleanup, incase of module init, the stats
memory needs to be cleaned up only it is already allocated. Accessing it
without validating it is allocated or not, leads to crash.

closes-bug: #1475558

Change-Id: Iaf0d67014174506d51bd9a46671e64d463d0db71

Jeba Paulaiyan (jebap) on 2015-09-17

information type:

Proprietary → Public