Peer validity check in route add enhancement

[Manish Singh]

In agent when route is enqueued, peer is specified. Ensure that whenever path from BGP peer is enqueued it undergoes validtiy check via agent route data before used for creation of path.
This enforces new code to implement validity check for any new data types to be used with BGP peer.

In future any other peer other than BGP, if needs this then it can also enforce same.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12069
Submitter: Manish Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12070
Submitter: Manish Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12318
Submitter: Manish Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/12318
Committed: http://github.org/Juniper/contrail-controller/commit/aec068bf89431090ceb6a5b1d248cbaed07bba02
Submitter: Zuul
Branch: master

commit aec068bf89431090ceb6a5b1d248cbaed07bba02
Author: Manish <email address hidden>
Date: Mon Jun 29 09:27:47 2015 +0530

Force peer validity check for BGP peer.

Extend the Peer class to specify if a validity check for peer
is needed whenver it is enqueued as a key paramater for DB request.
Currently BGP peer derived class falls into this category.
Any agent route data enqueued with BGP peer in key will have to
implement validity check.

Also remove NULL peer usages in agent key from test cases.

Closes-bug: 1466739

Conflicts:
 src/vnsw/agent/test-xml/test_xml_oper.cc

Change-Id: Ie764f15c023d5d2995f5b0d34d0a89d0d2546831

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12660
Submitter: Manish Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/12660
Committed: http://github.org/Juniper/contrail-controller/commit/da0ff12426969f97d74ba25f5bf59be9a58ef2d3
Submitter: Zuul
Branch: R2.20

commit da0ff12426969f97d74ba25f5bf59be9a58ef2d3
Author: Manish <email address hidden>
Date: Mon Jun 29 09:27:47 2015 +0530

Force peer validity check for BGP peer.

Extend the Peer class to specify if a validity check for peer
is needed whenver it is enqueued as a key paramater for DB request.
Currently BGP peer derived class falls into this category.
Any agent route data enqueued with BGP peer in key will have to
implement validity check.

Also remove NULL peer usages in agent key from test cases.

Closes-bug: 1466739

Conflicts:
 src/vnsw/agent/test-xml/test_xml_oper.cc

Conflicts:
 src/vnsw/agent/pkt/test/test_pkt_flowv6.cc
 src/vnsw/agent/pkt/test/test_sg_flowv6.cc
 src/vnsw/agent/test/SConscript

Conflicts:
 src/vnsw/agent/test/SConscript

Change-Id: Ifdb7af038e3bc9cf9be7d91b2aa7a7544746b6a9

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/13927
Submitter: Vinay Vithal Mahuli (<email address hidden>)