redis-server check causing upgrade to fail on Build 54

[Vedamurthy Joshi]

R2.20 Build 54 Ubuntu 14.04 Juno multi-node setup

Upgrade from 2.20 Build 45 to 54 failed :

Looks like the redis-server status check needs to be run in warn_only mode...

2015-06-16 20:09:46:264068: [root@10.204.217.147] out: [localhost] local: sudo service redis-server stop
2015-06-16 20:09:46:264183: [root@10.204.217.146] out: [root@10.204.217.148] out: [root@10.204.217.147] out: Stopping redis-server: redis-server.
[localhost] local: sudo sed -i -e 's/lua-time-limit.*/lua-time-limit 15000/' /etc/redis/redis.conf
[localhost] local: sudo sed -i -e '/^[ ]*dbfilename/s/^/#/' /etc/redis/redis.conf
2015-06-16 20:09:46:380465: 2015-06-16 20:09:46:380459: 2015-06-16 20:09:46:380437: [root@10.204.217.148] out: [localhost] local: sudo grep '^dbfilename' /etc/redis/redis.conf | awk '{print $2}'
2015-06-16 20:09:46:380649: [root@10.204.217.148] out: dump.rdb
2015-06-16 20:09:46:380932: [root@10.204.217.148] out: [localhost] local: sudo sed -i -e '/^[ ]*save/s/^/#/' /etc/redis/redis.conf
2015-06-16 20:09:46:381053: [root@10.204.217.148] out: [localhost] local: sudo sed -i -e '/^[ ]*dbfilename/s/^/#/' /etc/redis/redis.conf
2015-06-16 20:09:46:381180: [root@10.204.217.148] out: [localhost] local: sudo service redis-server start
2015-06-16 20:09:46:381286: [root@10.204.217.146] out: [localhost] local: sudo service redis-server start
2015-06-16 20:09:46:388217: [root@10.204.217.148] out: Starting redis-server: redis-server.
2015-06-16 20:09:46:582124: [root@10.204.217.148] out: [localhost] local: sudo service redis-server status | grep not
2015-06-16 20:09:46:582271: [root@10.204.217.148] out:
2015-06-16 20:09:46:589937: [root@10.204.217.148] out: Fatal error: local() encountered an error (return code 1) while executing 'sudo service redis-server status | grep not'
2015-06-16 20:09:46:590044: [root@10.204.217.148] out:
2015-06-16 20:09:46:590146: [root@10.204.217.148] out: Aborting.
2015-06-16 20:09:46:590264: [root@10.204.217.148] out:
2015-06-16 20:09:46:606112:

2015-06-16 20:09:46:611723: Fatal error: sudo() received nonzero return code 1 while executing!
2015-06-16 20:09:46:611723:
2015-06-16 20:09:46:611723: Requested: upgrade-vnc-collector --cassandra_ip_list 192.168.1.4 192.168.1.2 192.168.1.3 --cfgm_ip 192.168.1.30 --self_collector_ip 192.168.1.4 --num_nodes 3 --analytics_data_ttl 48 --analytics_config_audit_ttl -1 --analytics_statistics_ttl -1 --analytics_flow_ttl -1 --kafka_enabled None --keystone_ip 192.168.1.30 --keystone_admin_user admin --keystone_admin_passwd contrail123 --keystone_admin_tenant_name service --keystone_auth_protocol http --keystone_auth_port 35357 --keystone_admin_token 5ae016edc6dc7d36a972 --keystone_insecure False --internal_vip 192.168.1.30 -P contrail-openstack-analytics -F 2.20 -T 2.20

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11693
Submitter: Sundaresan Rajangam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11698
Submitter: Raj Reddy (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/11698
Committed: http://github.org/Juniper/contrail-provisioning/commit/12a71fea7ba633a664de52c87cd6dec107933960
Submitter: Zuul
Branch: R2.20

commit 12a71fea7ba633a664de52c87cd6dec107933960
Author: Raj Reddy <email address hidden>
Date: Tue Jun 16 14:39:20 2015 -0700

Fix issues in redis upgrade code. We have to set 'capture=True' to
local() if we want to capture the output
Closes-Bug: #1465733

Change-Id: I9419e712731ca7aceb43dac9f544feaf75612552