coverage build failure in bgp

[Vinay Mahuli]

coverage build was failing with compilation error for missing –lcrypto . We were able to resolve this.
But later on after fixing the issue of –lcrypto, we are facing below mentioned compilation errors.

The screen snapshot is as follows.
You can login to builder@10.204.217.209 with c0ntrail123 as password and run this command "/usr/bin/scons --optimization=coverage -j8 controller/src/bgp:test" to reproduce.

In file included from controller/src/bgp/test/bgp_xmpp_evpn_mcast_test.cc:6:0:
controller/src/bgp/test/bgp_xmpp_evpn_mcast_test.cc: In member function ‘bool BgpXmppEvpnMcastTestBase::VerifyVrouterInOListCommon(test::NetworkAgentMock*, int, const autogen::EnetItemType*, bool)’:
controller/src/base/test/task_test_util.h:75:34: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
         if ((expected) == (actual)) { \
                                  ^
controller/src/base/test/task_test_util.h:162:5: note: in expansion of macro ‘TASK_UTIL_WAIT_EQ’
     TASK_UTIL_WAIT_EQ(expected, actual, task_util_wait_time(), \
     ^
controller/src/bgp/test/bgp_xmpp_evpn_mcast_test.cc:185:21: note: in expansion of macro ‘TASK_UTIL_EXPECT_EQ’
                     TASK_UTIL_EXPECT_EQ(tag_, nh.label);
                     ^
controller/src/base/test/task_test_util.h:82:34: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
         if ((expected) == (actual)) { \
                                  ^
controller/src/base/test/task_test_util.h:162:5: note: in expansion of macro ‘TASK_UTIL_WAIT_EQ’
     TASK_UTIL_WAIT_EQ(expected, actual, task_util_wait_time(), \
     ^
controller/src/bgp/test/bgp_xmpp_evpn_mcast_test.cc:185:21: note: in expansion of macro ‘TASK_UTIL_EXPECT_EQ’
                     TASK_UTIL_EXPECT_EQ(tag_, nh.label);
                     ^
cc1plus: all warnings being treated as errors
scons: *** [build/coverage/bgp/test/bgp_xmpp_evpn_mcast_test.o] Error 1
scons: building terminated because of errors.
builder@coverage:/build/jenkins/workspace/Ubuntu_Tahr_Coverage_GitHub$

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11123
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11124
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/11123
Committed: http://github.org/Juniper/contrail-controller/commit/d8871d7e140c7ea1a0ab9b30bf8b862f0d4eec2b
Submitter: Zuul
Branch: R2.20

commit d8871d7e140c7ea1a0ab9b30bf8b862f0d4eec2b
Author: Nischal Sheth <email address hidden>
Date: Sun May 31 18:03:37 2015 -0700

Fix coverage build for trusty tahr

Change-Id: I7c3cfa7e8022e948d83146011f29b022af66c7bc
Closes-Bug: 1460552

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/11124
Committed: http://github.org/Juniper/contrail-controller/commit/be2639f507c5ed98c92cd22d23baf6eee565f713
Submitter: Zuul
Branch: master

commit be2639f507c5ed98c92cd22d23baf6eee565f713
Author: Nischal Sheth <email address hidden>
Date: Sun May 31 18:03:37 2015 -0700

Fix coverage build for trusty tahr

Change-Id: I7c3cfa7e8022e948d83146011f29b022af66c7bc
Closes-Bug: 1460552