Juniper Openstack

Endian issues in bgp open message identifier processing

  1. Series r2.20
  2. Bug #1450842
Bug #1450842 reported by Nischal Sheth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Committed
High
Nischal Sheth
Juniper Openstack r2.20-fcs
Trunk
Fix Committed
High
Nischal Sheth
Juniper Openstack r3.0-fcs

Bug Description

Noticed that JUNOS displays the router id for contrail control node
neighbors incorrectly. Further investigation uncovered a couple of
issues.

CN sends bgp identifier in open message in host byte order
CN assumes BgpProto::OpenMessage fields are in network byte order

These 2 bugs compensate for each other and operation between CNs
is fine. However it causes the following issues when interoperating
with other implementations:

- Connection collision logic in state machine doesn't work correctly
- Duplicate id detection code in open message validation is broken

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : master

Review in progress for https://review.opencontrail.org/9813
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.20

Review in progress for https://review.opencontrail.org/9816
Submitter: Nischal Sheth (<email address hidden>)

Nischal Sheth (nsheth)
no longer affects: juniperopenstack/r2.0
no longer affects: juniperopenstack/r2.1
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/9813
Committed: http://github.org/Juniper/contrail-controller/commit/6faad476fcaba575b2a14985b4941f9299a4725c
Submitter: Zuul
Branch: master

commit 6faad476fcaba575b2a14985b4941f9299a4725c
Author: Nischal Sheth <email address hidden>
Date: Thu Apr 30 22:14:00 2015 -0700

Fix endian issue with bgp identifier in open message

BgpProto::OpenMessage fields are in host byte order.
The Encode/Decode routines take care of serializing
and deserializing.

Fix the rest of the code based on the above.

Change-Id: I8c923405c4bc8a75a282ef7bc5f7fda04d92f0d8
Closes-Bug: #1450842

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/9816
Committed: http://github.org/Juniper/contrail-controller/commit/4d8d998b1abd7d8dc465102c878b29a934f1725c
Submitter: Zuul
Branch: R2.20

commit 4d8d998b1abd7d8dc465102c878b29a934f1725c
Author: Nischal Sheth <email address hidden>
Date: Thu Apr 30 22:14:00 2015 -0700

Fix endian issue with bgp identifier in open message

BgpProto::OpenMessage fields are in host byte order.
The Encode/Decode routines take care of serializing
and deserializing.

Fix the rest of the code based on the above.

Change-Id: I8c923405c4bc8a75a282ef7bc5f7fda04d92f0d8
Closes-Bug: #1450842

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.