Juniper Openstack

vrouter:memory leak in flow module

  1. Series r2.1
  2. Bug #1436798
Bug #1436798 reported by Anand H. Krishnan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R1.1
Fix Committed
High
Anand H. Krishnan
R1.30
Won't Fix
High
Anand H. Krishnan
R2.0
Fix Committed
High
Anand H. Krishnan
R2.1
Fix Committed
High
Anand H. Krishnan
R2.20
Fix Committed
Undecided
Anand H. Krishnan
Trunk
Fix Committed
Undecided
Anand H. Krishnan

Bug Description

Flow metadata, which is passed to the hold queue flusher, is not freed post the flush.

Tags: vrouter
Anand H. Krishnan (anandhk)
Changed in juniperopenstack:
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.1

Review in progress for https://review.opencontrail.org/8651
Submitter: Anand H. Krishnan (<email address hidden>)

Nagabhushana R (bhushana)
information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/8651
Committed: http://github.org/Juniper/contrail-vrouter/commit/88af46c26658a8560570df1083494a8afaf948a9
Submitter: Zuul
Branch: R2.1

commit 88af46c26658a8560570df1083494a8afaf948a9
Author: Anand H. Krishnan <email address hidden>
Date: Thu Mar 26 17:09:50 2015 +0530

Free the flow metadata post a flush

Flow metadata, which is passed to the hold queue flusher, is not freed
post the flush.

Change-Id: I7764f39167403532fe01caa2b1285a183420893b
Closes-Bug: #1436798

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : master

Review in progress for https://review.opencontrail.org/8678
Submitter: Anand H. Krishnan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/8678
Committed: http://github.org/Juniper/contrail-vrouter/commit/b041e68427abb1b7806a90ed34b8fb241639788d
Submitter: Zuul
Branch: master

commit b041e68427abb1b7806a90ed34b8fb241639788d
Author: Anand H. Krishnan <email address hidden>
Date: Thu Mar 26 17:09:50 2015 +0530

Free the flow metadata post a flush

Flow metadata, which is passed to the hold queue flusher, is not freed
post the flush.

Change-Id: I7764f39167403532fe01caa2b1285a183420893b
Closes-Bug: #1436798

Changed in juniperopenstack:
status: In Progress → Fix Committed
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.0

Review in progress for https://review.opencontrail.org/8708
Submitter: Anand H. Krishnan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R1.30

Review in progress for https://review.opencontrail.org/8709
Submitter: Anand H. Krishnan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R1.10

Review in progress for https://review.opencontrail.org/8710
Submitter: Anand H. Krishnan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/8709
Committed: http://github.org/Juniper/contrail-vrouter/commit/f807a8cbcf20a975b24fc98e559b86b2d37d8f50
Submitter: Zuul
Branch: R1.30

commit f807a8cbcf20a975b24fc98e559b86b2d37d8f50
Author: Anand H. Krishnan <email address hidden>
Date: Thu Mar 26 17:09:50 2015 +0530

Free the flow metadata post a flush

Flow metadata, which is passed to the hold queue flusher, is not freed
post the flush.

Change-Id: I7764f39167403532fe01caa2b1285a183420893b
Closes-Bug: #1436798

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/8710
Committed: http://github.org/Juniper/contrail-vrouter/commit/f81d90aa9dd92c83a06111c8b1ca3bc223ecd680
Submitter: Zuul
Branch: R1.10

commit f81d90aa9dd92c83a06111c8b1ca3bc223ecd680
Author: Anand H. Krishnan <email address hidden>
Date: Thu Mar 26 17:09:50 2015 +0530

Free the flow metadata post a flush

Flow metadata, which is passed to the hold queue flusher, is not freed
post the flush.

Change-Id: I7764f39167403532fe01caa2b1285a183420893b
Closes-Bug: #1436798

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/8708
Committed: http://github.org/Juniper/contrail-vrouter/commit/225b4e782b458faca54d669cd21e3ea68ef5a0e1
Submitter: Zuul
Branch: R2.0

commit 225b4e782b458faca54d669cd21e3ea68ef5a0e1
Author: Anand H. Krishnan <email address hidden>
Date: Thu Mar 26 17:09:50 2015 +0530

Free the flow metadata post a flush

Flow metadata, which is passed to the hold queue flusher, is not freed
post the flush.

Change-Id: I7764f39167403532fe01caa2b1285a183420893b
Closes-Bug: #1436798

Revision history for this message
Anand H. Krishnan (anandhk) wrote :

More leaks found.

Changed in juniperopenstack:
status: Fix Committed → In Progress
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.1

Review in progress for https://review.opencontrail.org/9284
Submitter: Anand H. Krishnan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R1.10

Review in progress for https://review.opencontrail.org/9292
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.1

Review in progress for https://review.opencontrail.org/9284
Submitter: Anand H. Krishnan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/9284
Committed: http://github.org/Juniper/contrail-vrouter/commit/f7f5478eba431d6d38fbd84b3e552ce412e3ced4
Submitter: Zuul
Branch: R2.1

commit f7f5478eba431d6d38fbd84b3e552ce412e3ced4
Author: Anand H. Krishnan <email address hidden>
Date: Mon Apr 20 12:41:11 2015 +0530

Free the defer data in case of errors

To make sure that we flush all the packets that are queued in a flow
entry, we run a defer function. If for any reason this defer was not
scheduled (because the function was called with no hold queue), the
defer data has to be freed.

Change-Id: Ideabe252ff6c56c6e01ccbc3a27044bac09933f3
Closes-BUG: #1436798

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/9292
Committed: http://github.org/Juniper/contrail-vrouter/commit/44c224691b44354c594ba786d59dfe17f99ec895
Submitter: Zuul
Branch: R1.10

commit 44c224691b44354c594ba786d59dfe17f99ec895
Author: Anand H. Krishnan <email address hidden>
Date: Mon Apr 20 12:41:11 2015 +0530

Free the defer data in case of errors

To make sure that we flush all the packets that are queued in a flow
entry, we run a defer function. If for any reason this defer was not
scheduled (because the function was called with no hold queue), the
defer data has to be freed.

Closes-BUG: #1436798
(cherry picked from commit 8c30ce9a3e254d45dc4de595cc066f2da21c18d6)

Conflicts:
 dp-core/vr_flow.c
Change-Id: Ideabe252ff6c56c6e01ccbc3a27044bac09933f3

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.0

Review in progress for https://review.opencontrail.org/9440
Submitter: Anand H. Krishnan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.20

Review in progress for https://review.opencontrail.org/9443
Submitter: Anand H. Krishnan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/9440
Committed: http://github.org/Juniper/contrail-vrouter/commit/e937aa9b4cace0eac361439403af5fa01355bfe2
Submitter: Zuul
Branch: R2.0

commit e937aa9b4cace0eac361439403af5fa01355bfe2
Author: Anand H. Krishnan <email address hidden>
Date: Mon Apr 20 12:41:11 2015 +0530

Free the defer data in case of errors

To make sure that we flush all the packets that are queued in a flow
entry, we run a defer function. If for any reason this defer was not
scheduled (because the function was called with no hold queue), the
defer data has to be freed.

Closes-BUG: #1436798
(cherry picked from commit 8c30ce9a3e254d45dc4de595cc066f2da21c18d6)

Fix improper boundary checks and reference count leaks

Boundary checks allow for one extra label than the maximum, causing
memory corruption. Also, when a label is changed, reference to old
nexthop has to be released. Two harmless boundary checks in nexthop
subysystem is also addressed.

Closes-BUG: #1446550
Change-Id: I9289265b8a843160fdfe6fffc3e52c131d9b2a4a

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/9443
Committed: http://github.org/Juniper/contrail-vrouter/commit/311b48c70ba74c79d141262188d4e15a336de368
Submitter: Zuul
Branch: R2.20

commit 311b48c70ba74c79d141262188d4e15a336de368
Author: Anand H. Krishnan <email address hidden>
Date: Mon Apr 20 12:41:11 2015 +0530

Free the defer data in case of errors

To make sure that we flush all the packets that are queued in a flow
entry, we run a defer function. If for any reason this defer was not
scheduled (because the function was called with no hold queue), the
defer data has to be freed.

Change-Id: Ideabe252ff6c56c6e01ccbc3a27044bac09933f3
Closes-BUG: #1436798

Hari Prasad Killi (haripk)
Changed in juniperopenstack:
status: In Progress → Fix Committed
Hari Prasad Killi (haripk)
Changed in juniperopenstack:
status: Fix Committed → In Progress
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12701
Submitter: Anand H. Krishnan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12701
Committed: http://github.org/Juniper/contrail-vrouter/commit/086fa60c8d28bb35b1190ffabde652af267a3c8e
Submitter: Zuul
Branch: master

commit 086fa60c8d28bb35b1190ffabde652af267a3c8e
Author: Anand H. Krishnan <email address hidden>
Date: Mon Apr 20 12:41:11 2015 +0530

Free the defer data in case of errors

To make sure that we flush all the packets that are queued in a flow
entry, we run a defer function. If for any reason this defer was not
scheduled (because the function was called with no hold queue), the
defer data has to be freed.

Change-Id: Ideabe252ff6c56c6e01ccbc3a27044bac09933f3
Closes-BUG: #1436798

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.