vrouter: kernel crash in linux_rx_handler

Bug #1430279 reported by Anand H. Krishnan
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Juniper Openstack
Fix Committed
Critical
Anand H. Krishnan
R2.1
Fix Committed
Critical
Anand H. Krishnan

Bug Description

Crash trace attached.

Once rps is done, the handler tries to extract vif from the control block. From that vif we try to get the dev and the rx_handler_data (which should be equal to the vif). From whatever information that was present in the trace, it was confirmed that rx_handler_data was null. There could be a case where agent restarts and is in the process of soft resetting the vrouter when this condition can happen. Since we do not have dump, for now we will provide a fix with the available information.

Tags: vrouter
Revision history for this message
Anand H. Krishnan (anandhk) wrote :
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.1

Review in progress for https://review.opencontrail.org/8211
Submitter: Anand H. Krishnan (<email address hidden>)

information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/8211
Committed: http://github.org/Juniper/contrail-vrouter/commit/f1e7b2da6553157d0ea3e24c45005387ce71cda6
Submitter: Zuul
Branch: R2.1

commit f1e7b2da6553157d0ea3e24c45005387ce71cda6
Author: Anand H. Krishnan <email address hidden>
Date: Tue Mar 10 17:28:26 2015 +0530

Validate vif to device and device to vif linkage before using vif

Once rps is done, the handler tries to extract vif from the control
block. From that vif we try to get the dev and the rx_handler_data
(which should be equal to the vif). From whatever information that
was present in the trace, it was confirmed that rx_handler_data was
null. There could be a case where agent restarts and is in the process
of soft resetting the vrouter when this condition can happen. Since
we do not have dump, for now we will check the linkages between vif
and device (<=>) before proceeding with packet processing.

Closes Bug: #1430279

Change-Id: I98066588c3c0d95f1327d505495f2058d9616a4d

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : master

Review in progress for https://review.opencontrail.org/8244
Submitter: Anand H. Krishnan (<email address hidden>)

Changed in juniperopenstack:
importance: Undecided → Critical
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/8244
Committed: http://github.org/Juniper/contrail-vrouter/commit/0d16880025a99fec0e30d4b6eea87e043542eb8b
Submitter: Zuul
Branch: master

commit 0d16880025a99fec0e30d4b6eea87e043542eb8b
Author: Anand H. Krishnan <email address hidden>
Date: Tue Mar 10 17:28:26 2015 +0530

Validate vif to device and device to vif linkage before using vif

Once rps is done, the handler tries to extract vif from the control
block. From that vif we try to get the dev and the rx_handler_data
(which should be equal to the vif). From whatever information that
was present in the trace, it was confirmed that rx_handler_data was
null. There could be a case where agent restarts and is in the process
of soft resetting the vrouter when this condition can happen. Since
we do not have dump, for now we will check the linkages between vif
and device (<=>) before proceeding with packet processing.

Closes Bug: #1430279

Change-Id: I98066588c3c0d95f1327d505495f2058d9616a4d

Changed in juniperopenstack:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.