Schema: SNAT: schema crash during delete of static_route_entry and not cleaning up dynamic gateway RI

[Senthilnathan Murugappan]

1) Schema didnt cleanup the dynamically created RI attached to gw network upon router gateway-clear.
2) schema crash during update route table when there were no static_route_entries (private vns are deleted)

Sachin is aware of it and have locally patched the same in the setup.

A problem occurred in a Python script.

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 3816, in launch_arc
    transformer.process_poll_result(result)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 3632, in process_poll_result
    virtual_network.update_route_table()
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 843, in update_route_table
    self.delete_route(prefix)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 812, in delete_route
    for static_route in static_route_entries.get_route() or []:
AttributeError: 'NoneType' object has no attribute 'get_route'

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10636
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10677
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10636
Committed: http://github.org/Juniper/contrail-controller/commit/3f55b9939e3738d300db8b6f5b66daae825251b3
Submitter: Zuul
Branch: R2.0

commit 3f55b9939e3738d300db8b6f5b66daae825251b3
Author: Sachin Bansal <email address hidden>
Date: Wed May 20 20:52:40 2015 -0700

Fixes for crashes in schema transformer

1. locate_routing_instance could fail if VN itself was deleted. Handle that case.
2. static_route_entries may not be present when route table entry is being deleted.
3. At reinit, use ri name instead of fq_name to find service chain id.

Change-Id: I56524610bc5fe370cb312a6cf633830911cf7e04
Closes-Bug: 1457223

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10677
Committed: http://github.org/Juniper/contrail-controller/commit/caa27e52123475eb90e9f0cf14d5a3fa803e431e
Submitter: Zuul
Branch: R2.1

commit caa27e52123475eb90e9f0cf14d5a3fa803e431e
Author: Sachin Bansal <email address hidden>
Date: Wed May 20 20:52:40 2015 -0700

Fixes for crashes in schema transformer

1. locate_routing_instance could fail if VN itself was deleted. Handle that case.
2. static_route_entries may not be present when route table entry is being deleted.
3. At reinit, use ri name instead of fq_name to find service chain id.

Change-Id: I56524610bc5fe370cb312a6cf633830911cf7e04
Closes-Bug: 1457223

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10865
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10869
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10865
Committed: http://github.org/Juniper/contrail-controller/commit/873a6d9e5c25f01154f6feaf4beca4646702a570
Submitter: Zuul
Branch: R2.20

commit 873a6d9e5c25f01154f6feaf4beca4646702a570
Author: Sachin Bansal <email address hidden>
Date: Wed May 20 20:52:40 2015 -0700

Fixes for crashes in schema transformer

1. locate_routing_instance could fail if VN itself was deleted. Handle that case.
2. static_route_entries may not be present when route table entry is being deleted.
3. At reinit, use ri name instead of fq_name to find service chain id.

Change-Id: I56524610bc5fe370cb312a6cf633830911cf7e04
Closes-Bug: 1457223

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10869
Committed: http://github.org/Juniper/contrail-controller/commit/7c08fa718de3a827b03537ef0084f6311817955e
Submitter: Zuul
Branch: master

commit 7c08fa718de3a827b03537ef0084f6311817955e
Author: Sachin Bansal <email address hidden>
Date: Wed May 20 20:52:40 2015 -0700

Fixes for crashes in schema transformer

1. locate_routing_instance could fail if VN itself was deleted. Handle that case.
2. static_route_entries may not be present when route table entry is being deleted.
3. At reinit, use ri name instead of fq_name to find service chain id.

Change-Id: I56524610bc5fe370cb312a6cf633830911cf7e04
Closes-Bug: 1457223