config: avoid reading mapping from useragent-kv if subnet uuid already known

Bug #1413864 reported by Hampapur Ajay
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R1.1
Fix Committed
High
Hampapur Ajay
R2.0
Fix Committed
High
Hampapur Ajay
R2.1
Fix Committed
High
Hampapur Ajay
Trunk
Fix Committed
High
Hampapur Ajay

Bug Description

At https://github.com/Juniper/contrail-controller/blob/master/src/config/vnc_openstack/vnc_openstack/neutron_plugin_db.py#L1336

        subnet_key = self._subnet_vnc_get_key(subnet_vnc, net_obj.uuid)
        sn_id = self._subnet_vnc_read_or_create_mapping(id=subnet_vnc.subnet_uuid,
                                                        key=subnet_key)

        sn_q_dict['id'] = sn_id

Reading of sn_id via useragent keyvalue datastore is only needed in for old subnets (before schema supported subnet_uuid). Doing this unconditionally causes net-list to slow down at scale.

Tags: neutron
Hampapur Ajay (hajay)
Changed in juniperopenstack:
assignee: nobody → Hampapur Ajay (hajay)
tags: added: neutron
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/7055
Committed: http://github.org/Juniper/contrail-controller/commit/5b753500d0d2f652488c981d14e7f63aa6717542
Submitter: Zuul
Branch: R1.10

commit 5b753500d0d2f652488c981d14e7f63aa6717542
Author: Hampapur Ajay <email address hidden>
Date: Thu Jan 22 21:39:00 2015 -0800

Do not read subnet-uuid from useragent kv if not necessary.

Since we don't check+store in useragent-kv for subnet mapping
in common case, handle this when neutron is asked about a subnet
it doesn't know (created by contrail API/UI) and do the mapping
store in the exception case.

Change-Id: Ia5531059b3eaecc3cff2bf5a3de671aad0a17bc3
Closes-Bug: #1413864
(cherry picked from commit a7bdf2fee2a8b8ba916a2e62a8317fb851b407a7)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/6525
Committed: http://github.org/Juniper/contrail-controller/commit/a7bdf2fee2a8b8ba916a2e62a8317fb851b407a7
Submitter: Zuul
Branch: master

commit a7bdf2fee2a8b8ba916a2e62a8317fb851b407a7
Author: Hampapur Ajay <email address hidden>
Date: Thu Jan 22 21:39:00 2015 -0800

Do not read subnet-uuid from useragent kv if not necessary.

Since we don't check+store in useragent-kv for subnet mapping
in common case, handle this when neutron is asked about a subnet
it doesn't know (created by contrail API/UI) and do the mapping
store in the exception case.

Change-Id: Ia5531059b3eaecc3cff2bf5a3de671aad0a17bc3
Closes-Bug: #1413864

Changed in juniperopenstack:
status: New → Fix Committed
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/7051
Committed: http://github.org/Juniper/contrail-controller/commit/bef10574842feebe6df1d79ec26319017ac3d0c9
Submitter: Zuul
Branch: R2.1

commit bef10574842feebe6df1d79ec26319017ac3d0c9
Author: Hampapur Ajay <email address hidden>
Date: Thu Jan 22 21:39:00 2015 -0800

Do not read subnet-uuid from useragent kv if not necessary.

Since we don't check+store in useragent-kv for subnet mapping
in common case, handle this when neutron is asked about a subnet
it doesn't know (created by contrail API/UI) and do the mapping
store in the exception case.

Change-Id: Ia5531059b3eaecc3cff2bf5a3de671aad0a17bc3
Closes-Bug: #1413864
(cherry picked from commit a7bdf2fee2a8b8ba916a2e62a8317fb851b407a7)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/7045
Committed: http://github.org/Juniper/contrail-controller/commit/9eeeb0b8e7d4afdfc4d64d40e23c7c013cd12ecc
Submitter: Zuul
Branch: R2.0

commit 9eeeb0b8e7d4afdfc4d64d40e23c7c013cd12ecc
Author: Hampapur Ajay <email address hidden>
Date: Thu Jan 22 21:39:00 2015 -0800

Do not read subnet-uuid from useragent kv if not necessary.

Since we don't check+store in useragent-kv for subnet mapping
in common case, handle this when neutron is asked about a subnet
it doesn't know (created by contrail API/UI) and do the mapping
store in the exception case.

Change-Id: Ia5531059b3eaecc3cff2bf5a3de671aad0a17bc3
Closes-Bug: #1413864
(cherry picked from commit a7bdf2fee2a8b8ba916a2e62a8317fb851b407a7)

Changed in juniperopenstack:
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.