tun: vrouter memory corruption
Bug #1394461 reported by
Anand H. Krishnan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Juniper Openstack |
Fix Committed
|
High
|
Anand H. Krishnan | ||
R2.0 |
Fix Committed
|
High
|
Anand H. Krishnan |
Bug Description
If a tun interface is added as the physical interface to the vrouter, packets that go out will not have a layer 2 header. The layer 3 unicast nexthops is shared across ipv4 and ipv6 and the layer 2 protocol field of the rewrite information is updated every time a packet hits the nexthop, based on whether the packet is ipv4 or ipv6. There are a couple of issues with this. One is that it is not MP safe and other is that the protocol field should be updated only if there is any rewrite information to be added. There will not be any rewrite information for packets egressing a tunnel interface.
Changed in juniperopenstack: | |
assignee: | nobody → Anand H. Krishnan (anandhk) |
tags: | added: vrouter |
information type: | Proprietary → Public |
Changed in juniperopenstack: | |
importance: | Undecided → High |
milestone: | none → r2.0-fcs |
To post a comment you must log in.
Reviewed: https:/ /review. opencontrail. org/4795 github. org/Juniper/ contrail- vrouter/ commit/ 8d4e68a82c46b30 124f180dacae2a8 e578a5a9a4
Committed: http://
Submitter: Zuul
Branch: master
commit 8d4e68a82c46b30 124f180dacae2a8 e578a5a9a4
Author: Anand H Krishnan <email address hidden>
Date: Wed Nov 19 22:13:23 2014 -0800
Layer 3 unicast nexthops should update layer 2 protocol fields only if
layer 2 information needs to be added.
Layer 3 unicast nexthops is shared across ipv4 and ipv6. The layer 2
protocol field of the rewrite information is updated every time a packet hits
the nexthop, based on whether the packet is ipv4 or ipv6. There are a couple
of issues with this way of doing things. One is that it is not MP safe and
other is that the protocol field should be updated only if there is any rewrite
information to be added.
There will not be any rewrite information for packets egressing a tunnel interface,
and hence the layer 2 protocol information should not be added.
Closes-BUG: #1394461 1f5971228269cfb c8a533518c6
Change-Id: If06c41127501ed