Juniper Openstack

'using namespace boost::uuids' used in header files

Bug #1803531 reported by Mateusz Jablonski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Undecided
Mateusz Jablonski
Juniper Openstack r5.1.0
OpenContrail
Fix Committed
Undecided
Mateusz Jablonski

Bug Description

'using namespace boost::uuids' should not be used in any header file. It can change code meaning in all other files that include this file.

Mateusz Jablonski (mateusz.jablonski)
Changed in opencontrail:
assignee: nobody → Mateusz Jablonski (mateusz.jablonski)
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47692
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47693
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47694
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47695
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47698
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47700
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47701
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47702
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47692
Committed: http://github.com/Juniper/contrail-controller/commit/6c697ed8c93b93e9efdf857b0479d4c8d7f3c58a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 6c697ed8c93b93e9efdf857b0479d4c8d7f3c58a
Author: Mateusz Jablonski <email address hidden>
Date: Thu Nov 15 12:45:38 2018 +0100

Use 'boost::uuids' directly in vnsw/agent/test directory

Preparing to remove 'using namespace boost::uuids'
from header files.

Change-Id: I4dc3143996e0016348898024cca2677e3491af3a
Partial-Bug: #1803531

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/47693
Committed: http://github.com/Juniper/contrail-controller/commit/941e37e6c15e58a8c9a48a5e0c1a32bf46ceb216
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 941e37e6c15e58a8c9a48a5e0c1a32bf46ceb216
Author: Mateusz Jablonski <email address hidden>
Date: Thu Nov 15 12:51:11 2018 +0100

Use 'boost::uuids' directly in vnsw/agent/oper/test directory

Preparing to remove 'using namespace boost::uuids'
from header files.

Change-Id: Ic7ef74a610ac53d2b76727a7c803d39cfb8c76fc
Partial-Bug: #1803531

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/47694
Committed: http://github.com/Juniper/contrail-controller/commit/066b66cd23ae07fd00c5c9417f71e64fd912497d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 066b66cd23ae07fd00c5c9417f71e64fd912497d
Author: Mateusz Jablonski <email address hidden>
Date: Thu Nov 15 12:54:05 2018 +0100

Use 'boost::uuids' directly in vnsw/agent/pkt/test directory

Preparing to remove 'using namespace boost::uuids'
from header files.

Change-Id: I84338542045b04f8a95019ad7a6b8057c5178453
Partial-Bug: #1803531

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/47695
Committed: http://github.com/Juniper/contrail-controller/commit/c9cd118977809c68ffa27e136186e02195576abb
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c9cd118977809c68ffa27e136186e02195576abb
Author: Mateusz Jablonski <email address hidden>
Date: Thu Nov 15 13:09:22 2018 +0100

Use 'boost::uuids' namespace directly in part of code

Preparing to remove 'using namespace boost::uuids'
from header files.

Change-Id: I58f4fd071e74195ad6562e41cbe848c4f632eff3
Partial-Bug: #1803531

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47698
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47702
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47700
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47701
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47698
Committed: http://github.com/Juniper/contrail-controller/commit/fefb834d5d8f147d9314d15544a27868149e3e21
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit fefb834d5d8f147d9314d15544a27868149e3e21
Author: Mateusz Jablonski <email address hidden>
Date: Thu Nov 15 16:02:02 2018 +0100

Use 'boost::uuids' directly in part of the code

Preparing to remove 'using namespace boost::uuids'
from header files

Change-Id: If9664d6157a9ff8f8d5ed6f8d51d23774209ba11
Partial-Bug: #1803531

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/47700
Committed: http://github.com/Juniper/contrail-controller/commit/31c82f15405a2e976a8c6feb7bf68f6a2488dd07
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 31c82f15405a2e976a8c6feb7bf68f6a2488dd07
Author: Mateusz Jablonski <email address hidden>
Date: Thu Nov 15 16:27:40 2018 +0100

Use 'boost::uuids' directly in part of 'oper' module

Preparing to remove 'using namespace boost::uuids'
from header files.

Change-Id: Ic5b2af2db256844839848244175ac38f8d9cb1e6
Partial-Bug: #1803531

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/47701
Committed: http://github.com/Juniper/contrail-controller/commit/a226193468abca9be5ddbfe3d27f678e32fae305
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit a226193468abca9be5ddbfe3d27f678e32fae305
Author: Mateusz Jablonski <email address hidden>
Date: Thu Nov 15 16:34:38 2018 +0100

Use 'boost::uuids' directly in part of the 'oper' module

Preparing to remove 'using namespace boost::uuids'
from header files.

Change-Id: Ia8b0882ecaa6c20071188384fa7bea43d3b688b0
Partial-Bug: #1803531

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47702
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47702
Committed: http://github.com/Juniper/contrail-controller/commit/607e0592877573afd9c76426de9f9b281e197158
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 607e0592877573afd9c76426de9f9b281e197158
Author: Mateusz Jablonski <email address hidden>
Date: Thu Nov 15 16:52:40 2018 +0100

Remove 'using namespace boost::uuids' from header files

Change-Id: I023221aa15cae1b96e912127338829d94224643d
Closes-Bug: #1803531

Mateusz Jablonski (mateusz.jablonski)
Changed in opencontrail:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.