Juniper Openstack

InetUnicastAgentRouteTable::InetRouteTree fails under Windows

Bug #1802130 reported by Jacek Iżykowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Undecided
Jacek Iżykowski
Juniper Openstack r5.1.0
OpenContrail
Fix Committed
Undecided
Unassigned

Bug Description

InetUnicastAgentRouteTable::InetRouteTree doesn't work under Windows ('Compare' always returns true due to undesired behavior of RtKey::ByteValue) in 'production' build when compiled with MS C++ 19.00.24210.

Tags: windows
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47527
Submitter: Jacek Izykowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47527
Committed: http://github.com/Juniper/contrail-controller/commit/27af3ef43c466e8d79798f50475ce92505f328a4
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 27af3ef43c466e8d79798f50475ce92505f328a4
Author: Jacek Iżykowski <email address hidden>
Date: Wed Nov 7 16:52:06 2018 +0100

Fix for RtKey under Windows (MS C++ 19.00.24210)

InetUnicastAgentRouteTable::InetRouteTree doesn't work under
Windows ('Compare' always returns true due to undesired behavior
of RtKey::ByteValue) in 'production' build when compiled with
MS C++ 19.00.24210.

This change provides:
1) fix for RtKey;
2) unit test that fails without the new change when compiled with
MS C++ 19.00.24210 in 'production' mode.

Closes-Bug: #1802130
Change-Id: I347e6b26ca8cbce60c5ab362eb273e67bc67b92a

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47786
Submitter: Jacek Izykowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47786
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47786
Committed: http://github.com/Juniper/contrail-build/commit/c32dc52c526082b61dd22a8faca98cb1cc25f051
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c32dc52c526082b61dd22a8faca98cb1cc25f051
Author: Jacek Iżykowski <email address hidden>
Date: Wed Nov 21 16:54:41 2018 +0100

Verify cl.exe version

Change-Id: I7b23faba2893f7851e67c9b3c914017ef76c92a8
Closes-bug: #1802130

Dariusz Sosnowski (dariusz.sosnowski)
Changed in opencontrail:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.