Introduce TX packet tests in vRouter on Windows

Bug #1796663 reported by Dariusz Sosnowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Undecided
Dariusz Sosnowski
OpenContrail
Fix Committed
Undecided
Unassigned

Bug Description

Introduce TX packet tests in vRouter on Windows to prevent regression in checksum, fragmentation and segmentation code paths.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46785
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46788
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46790
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46791
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46795
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46824
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46790
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46849
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46854
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46791
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46899
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46900
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46903
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46790
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46791
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46785
Committed: http://github.com/Juniper/contrail-vrouter/commit/b8f5a5bd945677e41fe76e2c1043b1a1204223b9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit b8f5a5bd945677e41fe76e2c1043b1a1204223b9
Author: Dariusz Sosnowski <email address hidden>
Date: Fri Oct 5 17:24:23 2018 +0200

windows: Extract helper functions in win_if_tx

- Extract VrInterfaceToDestination.
- Extract MarkNetBufferListAsSafe.

Change-Id: I7c90f47c2cbf485d7a8392dd734dad42d549b368
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46788
Committed: http://github.com/Juniper/contrail-vrouter/commit/cc597f584d578a92c2247115d947af2eb697df4d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit cc597f584d578a92c2247115d947af2eb697df4d
Author: Dariusz Sosnowski <email address hidden>
Date: Fri Oct 5 17:51:48 2018 +0200

windows: Introduce WinTxPostprocess in win_if_tx

This change introduces a first iteration of WinTxPostprocess, which would be
unit testable in user space. Right now it implements a logic from lines 261-266
of windows/vr_host_interface.c. Although it's not used right now, it is planned
that WinTxPostprocess will replace most of win_if_tx code in subsequent changes.

To make first iteration of WinTxPostprocess compilable in user space,
the following functions had to be copied and modified:

- fix_ip_csum_at_offset,
- zero_ip_csum_at_offset,
- fix_csum,
- fix_tunneled_csum,
- fix_ip_v4_csum.

Change-Id: I2a4ac48d7c422063194ba26265534f81a456b1a0
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46795
Committed: http://github.com/Juniper/contrail-vrouter/commit/d1aee60979ec814dc5b8849fdc37c5660c048fcf
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d1aee60979ec814dc5b8849fdc37c5660c048fcf
Author: Mateusz Jablonski <email address hidden>
Date: Mon Oct 8 17:29:13 2018 +0200

Windows: Use WIN_MULTI_PACKET if WinTxPostprocess

Change-Id: Ifac025243ea5b4b3826f2a5c6cb8bd9caab1c9f3
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46824
Committed: http://github.com/Juniper/contrail-vrouter/commit/9daadd119acf466a6813f43ef41620c22e6ec714
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 9daadd119acf466a6813f43ef41620c22e6ec714
Author: Mateusz Jablonski <email address hidden>
Date: Tue Oct 9 14:10:46 2018 +0200

Windows: Refactor SplittingContext

Remove all kernel mode types from SplittingContext

Change-Id: I4e408d4634c128e44c353ef0e9ece5f20b09683d
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46945
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46791
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46791
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46791
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47071
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47071
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46849
Committed: http://github.com/Juniper/contrail-vrouter/commit/d6b1473ab7c87e53adb62b764f65f6678c3ca064
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d6b1473ab7c87e53adb62b764f65f6678c3ca064
Author: Mateusz Jablonski <email address hidden>
Date: Wed Oct 10 11:07:16 2018 +0200

Windows: Refactor packet metadata management code

Change-Id: I1ac39b6d71ee1c41e4067150329ddb8727cf2154
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46854
Committed: http://github.com/Juniper/contrail-vrouter/commit/5044d2bb362415d85dfe1b5991646029dff8fad1
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 5044d2bb362415d85dfe1b5991646029dff8fad1
Author: Mateusz Jablonski <email address hidden>
Date: Wed Oct 10 13:06:16 2018 +0200

Windows: Refactor packet splitting

Change-Id: I7e0ff5f9c95814454753e931ac087b66c01d8795
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46899
Committed: http://github.com/Juniper/contrail-vrouter/commit/872c02d79541dd2783f296aff7c6857ab4d4a406
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 872c02d79541dd2783f296aff7c6857ab4d4a406
Author: Mateusz Jablonski <email address hidden>
Date: Thu Oct 11 11:27:20 2018 +0200

Windows: Refactor WinPacketRaw implementation. Add new functionality.

Change-Id: Id6560a6e16f0c4c613504c04c0c30e6a0a40b067
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46900
Committed: http://github.com/Juniper/contrail-vrouter/commit/9fb8af0e017916eaa3b0469271f8f08ad993418d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 9fb8af0e017916eaa3b0469271f8f08ad993418d
Author: Mateusz Jablonski <email address hidden>
Date: Thu Oct 11 11:54:53 2018 +0200

Windows: Use WinPacketRaw abstraction in packet splitting code

Change-Id: I83c97f8a80aefe604a11d40fedbe75225cf7ff14
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46903
Committed: http://github.com/Juniper/contrail-vrouter/commit/170ab1e797bf2cd70c63dcd20a79d93b571d1ef9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 170ab1e797bf2cd70c63dcd20a79d93b571d1ef9
Author: Mateusz Jablonski <email address hidden>
Date: Thu Oct 11 13:23:23 2018 +0200

Windows: Refactor 'win_pgso_size' callback

Change-Id: Id6ae9732d681f17cd24d507adbd3cbeb5d37e2ba
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46790
Committed: http://github.com/Juniper/contrail-vrouter/commit/1794dd78d2dd3ced1c1d3f8088b19b612436f54e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 1794dd78d2dd3ced1c1d3f8088b19b612436f54e
Author: Dariusz Sosnowski <email address hidden>
Date: Mon Oct 8 15:51:21 2018 +0200

windows: Decouple WinTxPostprocess from dp-core

WinTxPostprocess indirectly uses vr_data_at_offset callback through dp-core.
This coupling causes linking problems because of vrouter_host structure.
Proposed solution is to use underlying callback directly. This change extracts
this callback and makes it compilable in user space.

Change-Id: Iea4c7d4ac2c33b3837a5d0a5721e1cd3ff0d6266
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47071
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46791
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47071
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46945
Committed: http://github.com/Juniper/contrail-vrouter/commit/00046ec6020d67bdc3a963eb8592c18c53a6c3d9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 00046ec6020d67bdc3a963eb8592c18c53a6c3d9
Author: Mateusz Jablonski <email address hidden>
Date: Fri Oct 12 12:56:57 2018 +0200

Windows: Add required fake WinPakcetRaw empty implementations

Change-Id: Ic73a80bb3719d92b688b95275cab1a936a662ef5
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47071
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46791
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47071
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46791
Committed: http://github.com/Juniper/contrail-vrouter/commit/c7fa0ffd705ad3403ca4c9ae9ee7bb2572e93834
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c7fa0ffd705ad3403ca4c9ae9ee7bb2572e93834
Author: Mateusz Jablonski <email address hidden>
Date: Fri Oct 12 13:04:22 2018 +0200

windows: Unit test tunneled IP/UDP packet

This change introduces a unit test for WinTxPostprocess
function, which verifies how it handles IP/UDP packet encapsulated
in MPLSoGRE header, assuming that checksum offloading was requested
by container.

Change-Id: I2f80bc6c281d39fdfd3bcd95e286adb56bb990eb
Co-authored-by: Dariusz Sosnowski <email address hidden>
Co-authored-by: Mateusz Jablonski <email address hidden>
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47290
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47292
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47292
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47292
Submitter: Jacek Chalupka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47392
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47292
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47396
Submitter: Jacek Chalupka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47392
Committed: http://github.com/Juniper/contrail-vrouter/commit/d56b661b53a211a11192ee907b2a73a96c7236eb
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d56b661b53a211a11192ee907b2a73a96c7236eb
Author: Mateusz Jablonski <email address hidden>
Date: Wed Oct 31 13:10:27 2018 +0100

Windows: Remove precompiled headers

Change-Id: Id682af99656cf838e4727296cd78cc3def48d75c
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/47290
Committed: http://github.com/Juniper/contrail-vrouter/commit/89ecc14f373723a85288a8690c3a10c7b1a5ab0e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 89ecc14f373723a85288a8690c3a10c7b1a5ab0e
Author: Mateusz Jablonski <email address hidden>
Date: Fri Oct 26 11:19:05 2018 +0200

Windows: Fix freeing contiguous memory block of packet data

Change-Id: Ic017529e9b1bb72d34a09478850ad2eb53276a7a
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47566
Submitter: Jacek Chalupka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47292
Committed: http://github.com/Juniper/contrail-vrouter/commit/3d9f7ca823d49af0faf99f222f6ddac52c2f54ff
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 3d9f7ca823d49af0faf99f222f6ddac52c2f54ff
Author: Mateusz Jablonski <email address hidden>
Date: Fri Oct 26 12:23:21 2018 +0200

Windows: Fix TCP segmentation

- Clear Large Send Offload flag after segmentation
- Fix inner TCP packet checksum calculation
- Introduce TCP segmentation tests

Change-Id: Ib0cfb13b73a696b69499db6c6503aad2d83e46fb
Co-authored-by: Dariusz Sosnowski <email address hidden>
Co-authored-by: Mateusz Jablonski <email address hidden>
Co-authored-by: Jacek Chalupka <email address hidden>
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/47396
Committed: http://github.com/Juniper/contrail-vrouter/commit/d3319be565d771251ee7938019f0c9b4b033a240
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d3319be565d771251ee7938019f0c9b4b033a240
Author: Jacek Chalupka <email address hidden>
Date: Wed Oct 31 16:55:44 2018 +0100

Moved Windows TX Postprocess

Change-Id: I1a71cfceba1391f4b61dd85e3365a26853d22b05
Partial-Bug: #1796663

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47566
Submitter: Jacek Chalupka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47566
Committed: http://github.com/Juniper/contrail-vrouter/commit/0c426c5104963774811a7c1980dd373d28256111
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 0c426c5104963774811a7c1980dd373d28256111
Author: Jacek Chalupka <email address hidden>
Date: Thu Nov 8 12:09:14 2018 +0100

Preparation for adding more tests

Change-Id: Iba5625451ca1f086afb757a12d43664c2074508b
Partial-Bug: #1796663

Changed in opencontrail:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.