Juniper Openstack

Expanad tabs and remove trailing spaces in contrail code

Bug #1765458 reported by Ananth Suryanarayana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Fix Committed
Low
Ananth Suryanarayana
Juniper Openstack r5.0.1
Trunk
Fix Committed
Low
Ananth Suryanarayana
Juniper Openstack r5.1.0

Bug Description

In a recent code review, unmodified code had trailing spaces which always show up in "Red" in git diff and in gerrit. Instead of a point fix, clean the entire C++ code base to expand tabs to spaces and also remove all trailing spaces.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42189
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42190
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42189
Submitter: Ananth Suryanarayana (<email address hidden>)

Jeba Paulaiyan (jebap)
tags: added: contrail-control
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42189
Committed: http://github.com/Juniper/contrail-controller/commit/cf594fbeb12ea2e66c2f4d974b485796e5aac7f0
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit cf594fbeb12ea2e66c2f4d974b485796e5aac7f0
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Apr 19 09:25:51 2018 -0700

Expanad tabs and remove trailing spaces

In a recent code review, unmodified code had trailing spaces which
always show up in "Red" in git diff and in gerrit. Instead of a point
fix, clean the entire C++ code base to expand tabs to spaces and also
remove all trailing spaces.

This may parts of code difficult for back-porting to other branches but
this code hygiene has been pending for a while. Hence we may only back
port to R5.0.

Change-Id: I24fec35e5c84de9819ab83a14546b0fa22b42fad
Partial-Bug: 1765458

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42190
Committed: http://github.com/Juniper/contrail-controller/commit/d9edd3ce0c87fca1b6941d1700ab9661f6a4538c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit d9edd3ce0c87fca1b6941d1700ab9661f6a4538c
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Apr 19 09:36:13 2018 -0700

Expanad tabs and remove trailing spaces

In a recent code review, unmodified code had trailing spaces which
always show up in "Red" in git diff and in gerrit. Instead of a point
fix, clean the entire C++ code base to expand tabs to spaces and also
remove all trailing spaces.

This may parts of code difficult for back-porting to other branches but
this code hygiene has been pending for a while. Hence we may only back
port to R5.0.

Change-Id: I24fec35e5c84de9819ab83a14546b0fa22b42fad
Partial-Bug: 1765458

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.