R4.0 SM fails to provision cluster with non-container package

[wenqing liang]

4.0.2.0-35~mitaka SM fails to provision a r3.2.6.0-60 mitaka cluster with the following error:

"2018-04-02 12:47:27,579-ERROR-server_mgr_main.py:4775-log_trace(): Traceback (most recent call last):
"
"2018-04-02 12:47:27,580-ERROR-server_mgr_main.py:4775-log_trace(): File "/opt/contrail/server_manager/server_mgr_main.py", line 6764, in provision_server
    self.prepare_provision(ret_data)
"
"2018-04-02 12:47:27,580-ERROR-server_mgr_main.py:4775-log_trace(): File "/opt/contrail/server_manager/server_mgr_main.py", line 6671, in prepare_provision
    server, cluster, role_servers, cluster_servers, package)
"
"2018-04-02 12:47:27,581-ERROR-server_mgr_main.py:4775-log_trace(): File "/opt/contrail/server_manager/server_mgr_main.py", line 6568, in build_calculated_provision_params
    self.build_calculated_inventory_params(cluster, cluster_servers, package)
"
"2018-04-02 12:47:27,581-ERROR-server_mgr_main.py:4775-log_trace(): File "/opt/contrail/server_manager/server_mgr_main.py", line 6321, in build_calculated_inventory_params
    role, package)
"
"2018-04-02 12:47:27,582-ERROR-server_mgr_main.py:4775-log_trace(): File "/opt/contrail/server_manager/server_mgr_main.py", line 7293, in set_container_image_for_role
    img = self.get_container_image_for_role(x, package)
"
"2018-04-02 12:47:27,582-ERROR-server_mgr_main.py:4775-log_trace(): File "/opt/contrail/server_manager/server_mgr_main.py", line 7279, in get_container_image_for_role
    for x in pparams['containers']:
"
"2018-04-02 12:47:27,583-ERROR-server_mgr_main.py:4775-log_trace(): KeyError: 'containers'
"

root@cmbu-auto-esx1-lnx02:~# server-manager display image --image_id combined_image_mainline -d
{
    "image": [
        {
            "category": "package",
            "id": "combined_image_mainline",
            "parameters": {
                "contrail-container-package": false,
                "kickseed": "",
                "kickstart": "",
                "puppet_manifest_version": "combined_image_mainline",
                "puppet_version": 3.0,
                "sequence_provisioning_available": true,
                "sku": "13.1.2-1",
                "version": "3.2.10.0-124"
            },
            "path": "/root/contrail-install-packages-3.2.10.0-124~mitaka.el7.centos.noarch.rpm",
            "type": "contrail-centos-package",
            "version": "3.2.9-124"
        }
    ]
}

root@cmbu-auto-esx1-lnx02:~# server-manager display server -d | grep contrail_4
root@cmbu-auto-esx1-lnx02:~# server-manager display cluster -d | grep contrail_4
root@cmbu-auto-esx1-lnx02:~#

[Abhay Joshi (abhayj)]

SM is not available 5.x onwards, hence marking the instance as invalid.