Security Group and Virtual Network ID still allocated by schema transformer

[Édouard Thuleau]

The bug [0] and [1] moved the VN and SG ID allocation from the schema-transformer to the API server to allocate ID synchronously with resource creation. But to prevent any issue in production upgrade, it keeps allocations in both places during at least one release overlaps.
It was merge for release 3.2, and 2 releases (4.0 and 4.1) kept ID allocations in both places after that so we can remove allocation from the schema-transformer on master (future 5.0 release).

[0] https://bugs.launchpad.net/juniperopenstack/+bug/1601919
[1] https://bugs.launchpad.net/opencontrail/+bug/1602285

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/36592
Submitter: Édouard Thuleau (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/36592
Submitter: ?douard Thuleau (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/36592
Committed: http://github.com/Juniper/contrail-controller/commit/aa242f2010322f658ca17a7777762da1d848100c
Submitter: Zuul (<email address hidden>)
Branch: master

commit aa242f2010322f658ca17a7777762da1d848100c
Author: Édouard Thuleau <email address hidden>
Date: Tue Oct 17 15:57:55 2017 +0200

[config] Remove VN and SG ID allocation from ST

Since patch [0] and [1] virtual networks and security group ID
allocations are done synchronously from the API server resource class
hook and could also allocated from the schema-transformer (it was keep
for upgrade reasons). That changed was made more that 2 releases now
(3.2), so we can safely remove allocation from the schema-transformer.

That patch is also hardening API server ID allocation methods for virtual
network, security group, tag type and tag:
- allocation is not removed if the value associated to the lock does not
correspond to the resource deallocated;
- when an API node received an ID allocation notification, it only
updates the memory allocation cache (it does not touch zookeeper).

[0] https://bugs.launchpad.net/juniperopenstack/+bug/1601919
[1] https://bugs.launchpad.net/opencontrail/+bug/1602285
Closes-Bug: #1724254

Change-Id: I4d48bd06d3b6bc417774d60caaa3bd83632d136d