alarm rule based on stats results in continuous generation of alarms

[Sundaresan Rajangam]

"alarm": {
        "alarm_rules": {
            "or_list": [
                {
                    "and_list": [
                        {
                            "operand1": "UveVirtualNetworkAgent.in_stats.tpkts",
                            "operand2": {
                                "json_value": "1500"
                            },
                            "operation": ">=",
                            "variables": [
                                "UveVirtualNetworkAgent.in_stats.other_vn"
                            ]
                        }
                    ]
                }
            ]
        }

The expectation for the above alarm rule is that if the value of UveVirtualNetworkAgent.in_stats.tpkts becomes greater than or equal to 1500, then the alarm should be raised. However, if the value of UveVirtualNetworkAgent.in_stats.tpkts keeps incrementing, then the contrail-alarm-gen continuously generates alarm with the latest value of UveVirtualNetworkAgent.in_stats.tpkts

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26878
Submitter: Sundaresan Rajangam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/26878
Committed: http://github.org/Juniper/contrail-controller/commit/41e31bb35b576718377e31dd532396f9c8b99a73
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 41e31bb35b576718377e31dd532396f9c8b99a73
Author: Sundaresan Rajangam <email address hidden>
Date: Tue Dec 6 00:26:19 2016 -0800

alarm rule based on stats results in continuous generation of alarms

For the alarm rule with operations >=, >, <=, <, range, the change in
operand value results in continuous generation of alarms. The
expectation is that the alarm should be raised only once.

This patch fixes this issue by ignoring the operand values if the
operation is any of [>=, >, <=, <, range] while comparing the existing
alarm with new alarm.

Change-Id: I8964626f439d4b873cf18b5fe36e820cec1e9ffc
Closes-Bug: #1616685

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26980
Submitter: Sundaresan Rajangam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26982
Submitter: Sundaresan Rajangam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/26980
Committed: http://github.org/Juniper/contrail-controller/commit/1c4858311cb7c4b56a139a543a5cb4b2e9ba293d
Submitter: Zuul (<email address hidden>)
Branch: master

commit 1c4858311cb7c4b56a139a543a5cb4b2e9ba293d
Author: Sundaresan Rajangam <email address hidden>
Date: Tue Dec 6 00:26:19 2016 -0800

alarm rule based on stats results in continuous generation of alarms

For the alarm rule with operations >=, >, <=, <, range, the change in
operand value results in continuous generation of alarms. The
expectation is that the alarm should be raised only once.

This patch fixes this issue by ignoring the operand values if the
operation is any of [>=, >, <=, <, range] while comparing the existing
alarm with new alarm.

Change-Id: I8964626f439d4b873cf18b5fe36e820cec1e9ffc
Closes-Bug: #1616685
(cherry picked from commit 41e31bb35b576718377e31dd532396f9c8b99a73)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/26982
Committed: http://github.org/Juniper/contrail-controller/commit/ddf55fa8958cf2868b9e44dd0ecb8a67d66541dd
Submitter: Zuul (<email address hidden>)
Branch: R3.1

commit ddf55fa8958cf2868b9e44dd0ecb8a67d66541dd
Author: Sundaresan Rajangam <email address hidden>
Date: Tue Dec 6 00:26:19 2016 -0800

alarm rule based on stats results in continuous generation of alarms

For the alarm rule with operations >=, >, <=, <, range, the change in
operand value results in continuous generation of alarms. The
expectation is that the alarm should be raised only once.

This patch fixes this issue by ignoring the operand values if the
operation is any of [>=, >, <=, <, range] while comparing the existing
alarm with new alarm.

Change-Id: I8964626f439d4b873cf18b5fe36e820cec1e9ffc
Closes-Bug: #1616685
(cherry picked from commit 41e31bb35b576718377e31dd532396f9c8b99a73)