Add vrouter version to kernel module

Bug #1605191 reported by Slobodan Blatnjak on 2016-07-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Low
Anand H. Krishnan

Bug Description

The kernel module for the vrouter is not properly versioned. So it cannot be inspected with lsmod.

Current behaviour:

# modinfo vrouter
filename: /lib/modules/3.13.0-92-generic/updates/dkms/vrouter.ko
version: 1.0
license: GPL
srcversion: 86FE61ACD774E38372BBA23
depends:
vermagic: 3.13.0-92-generic SMP mod_unload modversions
parm: vr_flow_entries:uint
parm: vr_oflow_entries:uint
parm: vr_bridge_entries:uint
parm: vr_bridge_oentries:uint
parm: vr_mpls_labels:uint
parm: vr_nexthops:uint
parm: vr_vrfs:uint
parm: vrouter_dbg:Set 1 for pkt dumping and 0 to disable, default value is 0 (int)

Desired behaviour:

# modinfo vrouter
filename: /lib/modules/3.13.0-92-generic/updates/dkms/vrouter.ko
version: 2.21.2-43
license: GPL
srcversion: 86FE61ACD774E38372BBA23
depends:
vermagic: 3.13.0-92-generic SMP mod_unload modversions
parm: vr_flow_entries:uint
parm: vr_oflow_entries:uint
parm: vr_bridge_entries:uint
parm: vr_bridge_oentries:uint
parm: vr_mpls_labels:uint
parm: vr_nexthops:uint
parm: vr_vrfs:uint
parm: vrouter_dbg:Set 1 for pkt dumping and 0 to disable, default value is 0 (int)

tags: added: ebay
tags: added: vrouter
affects: opencontrail → juniperopenstack
Changed in juniperopenstack:
importance: Undecided → Medium
assignee: nobody → Anand H. Krishnan (anandhk)
Hari Prasad Killi (haripk) wrote :

The version info is available in "vrouter --info" output.

Slobodan Blatnjak (sblatnjak) wrote :

Customer still think it would be good practice to have the modinfo show the correct version as well (low priority)

Changed in juniperopenstack:
importance: Medium → Low

Review in progress for https://review.opencontrail.org/32203
Submitter: Anand H. Krishnan (<email address hidden>)

Reviewed: https://review.opencontrail.org/32203
Committed: http://github.com/Juniper/contrail-build/commit/4da5acf38b8e8c2302db3823ddec808444837ce6
Submitter: Zuul (<email address hidden>)
Branch: master

commit 4da5acf38b8e8c2302db3823ddec808444837ce6
Author: Anand H. Krishnan <email address hidden>
Date: Fri May 26 14:09:05 2017 +0530

Add GetBuildVersion as a method in the env

vRouter needs build/version information as a string literal. Adding
GetBuildVersion to the environment as a method and using that in
the SConscript is probably the cleanest way of getting to the version
string.

Change-Id: If892739ffdf24ed7dc0aed8fb475c5bd798ee1a0
Partial-Bug: #1605191

Review in progress for https://review.opencontrail.org/32240
Submitter: Anand H. Krishnan (<email address hidden>)

Reviewed: https://review.opencontrail.org/32240
Committed: http://github.com/Juniper/contrail-vrouter/commit/41af9b3f9a320a98309833c54fa5dfd8b7072bb6
Submitter: Zuul (<email address hidden>)
Branch: master

commit 41af9b3f9a320a98309833c54fa5dfd8b7072bb6
Author: Anand H. Krishnan <email address hidden>
Date: Mon May 29 12:04:03 2017 +0530

Set the module version id to that of the release id

Get the build version from the environment and use that to set
the kernel module's version id. For DKMS, the version id is
passed as an argument to the gen_build_info script.

Change-Id: Iebc576983cd2ff00dcc7cf4c04b9f95d0a21b102
Closes-Bug: #1605191

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers