Vrouter Agent Stablization and disable flow eviction in vrouter

[Prabhjot Singh Sethi]

Tracking bug to fix vrouter agent stability
and disable tcp flow eviction in vrouter

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17964
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17967
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17964
Committed: http://github.org/Juniper/contrail-vrouter/commit/d44296e70bb4f1b7fab42d454cef125d3d4479e3
Submitter: Zuul
Branch: R3.0

commit d44296e70bb4f1b7fab42d454cef125d3d4479e3
Author: Prabhjot Singh Sethi <email address hidden>
Date: Sat Feb 27 23:21:58 2016 +0530

Disable Eviction of flow in Vrouter

Vrouter will track tcp flags, but will not evict the flow
entry once the session is closed and let vrouter agent
look at the flag to delete the flow eventually.

This is required till vrouter agent handles evict event
in a more stable way

Partial-Bug: 1550759
Change-Id: Ic7074442b22fc2c11362274e4e390654f3f2400a

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17967
Committed: http://github.org/Juniper/contrail-controller/commit/032214b955c50da464dc44cd8fef5c724cb95fb2
Submitter: Zuul
Branch: R3.0

commit 032214b955c50da464dc44cd8fef5c724cb95fb2
Author: Prabhjot Singh Sethi <email address hidden>
Date: Sun Feb 28 00:00:22 2016 +0530

Flow Eviction disable and other fixes

Issue:
------
Flow Eviction was leading to some unhandled events causing
stability issues in vrouter agent.

Fix:
----
- Remove Eviction based handling from ksync index manager
state machine
- stats collector to read TCP flags and trigger delete for
closed session, without waiting for aging
- other minor fixes

Closes-Bug: 1550759
Change-Id: I6f2f9a2d916c99aa53e03f33cf684d28de747df3

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18020
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18020
Committed: http://github.org/Juniper/contrail-controller/commit/730eda40f3c07d9254be41b5054d332c62cd8f70
Submitter: Zuul
Branch: R3.0

commit 730eda40f3c07d9254be41b5054d332c62cd8f70
Author: Prabhjot Singh Sethi <email address hidden>
Date: Mon Feb 29 15:59:09 2016 +0530

Remove unused Evict state changes

Issue:
------
vrouter agent still tries to evict another flow if due
to a race condition two flows end up using same index
for a transient time, causing eviction code trigger.

Fix:
----
remove evict state machine transistion and mutex lock
acquire, that are not required

Closes-Bug: 1551162
Closes-Bug: 1550759
Change-Id: I376938bbf48b2a7c066c819a1f956af2932e4811

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18113
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18116
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18113
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18116
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18113
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18113
Committed: http://github.org/Juniper/contrail-controller/commit/124d11b676a7094652c5cd0743a9f83a8ffffdc5
Submitter: Zuul
Branch: master

commit 124d11b676a7094652c5cd0743a9f83a8ffffdc5
Author: Prabhjot Singh Sethi <email address hidden>
Date: Sun Feb 28 00:00:22 2016 +0530

Flow Eviction disable and other fixes

Issue:
------
Flow Eviction was leading to some unhandled events causing
stability issues in vrouter agent.

Fix:
----
- Remove Eviction based handling from ksync index manager
state machine
- stats collector to read TCP flags and trigger delete for
closed session, without waiting for aging
- other minor fixes

(cherry picked from commit f77fdb9909b1aa9e03bc25d1aec4042ca0478a11)
Closes-Bug: 1550759
Change-Id: I6f2f9a2d916c99aa53e03f33cf684d28de747df3

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18209
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18212
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18209
Committed: http://github.org/Juniper/contrail-vrouter/commit/6ff5582eb4ac3e030f6ab6c06b30021909a0a4b3
Submitter: Zuul
Branch: R2.20

commit 6ff5582eb4ac3e030f6ab6c06b30021909a0a4b3
Author: Prabhjot Singh Sethi <email address hidden>
Date: Sat Feb 27 23:21:58 2016 +0530

Disable Eviction of flow in Vrouter

Vrouter will track tcp flags, but will not evict the flow
entry once the session is closed and let vrouter agent
look at the flag to delete the flow eventually.

This is required till vrouter agent handles evict event
in a more stable way

Change-Id: I4aa0878f240e92988f8d84e054a2635852d40b7f
Partial-Bug: 1550759

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18212
Committed: http://github.org/Juniper/contrail-vrouter/commit/966f27eeb0f508319d566091a7ae866eb56b8408
Submitter: Zuul
Branch: R2.22.x

commit 966f27eeb0f508319d566091a7ae866eb56b8408
Author: Prabhjot Singh Sethi <email address hidden>
Date: Sat Feb 27 23:21:58 2016 +0530

Disable Eviction of flow in Vrouter

Vrouter will track tcp flags, but will not evict the flow
entry once the session is closed and let vrouter agent
look at the flag to delete the flow eventually.

This is required till vrouter agent handles evict event
in a more stable way

Change-Id: I4aa0878f240e92988f8d84e054a2635852d40b7f
Partial-Bug: 1550759

Vrouter to generate EEXIST error appropriately

Vrouter to generate EEXIST error when flow add request
failed due to race between agent and datapath, where
flow entry was already created due to packet trap

Closes-Bug: 1547501
Change-Id: I0d2073622b06998dd5778fb94749958afc09bac0
(cherry picked from commit c17b4d4c45270d63a704d7e0cd9e04c5f8e4ad4f)
(cherry picked from commit b679020e0382a0c2f0bd8b4b84c22671441885df)

Vrouter to return error for invalid flow op

If a flow operation is requested for an index which
is not active, vrouter should return an ENOENT error
for such operation

Closes-Bug: 1548678
Change-Id: I42bbd58f41a868b1ce630046ae40e911df0d9491
(cherry picked from commit 1cf37614abb25bca4a93e8101f1af68a77a59552)
(cherry picked from commit 99763a1fa5509e4fe2384ee36bdb300bc26f1352)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18257
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18257
Committed: http://github.org/Juniper/contrail-vrouter/commit/7ddc290e4d8fcf21d6af1d7adfdb4c082ae95f40
Submitter: Zuul
Branch: master

commit 7ddc290e4d8fcf21d6af1d7adfdb4c082ae95f40
Author: Prabhjot Singh Sethi <email address hidden>
Date: Sat Feb 27 23:21:58 2016 +0530

Disable Eviction of flow in Vrouter

Vrouter will track tcp flags, but will not evict the flow
entry once the session is closed and let vrouter agent
look at the flag to delete the flow eventually.

This is required till vrouter agent handles evict event
in a more stable way

Partial-Bug: 1550759
Change-Id: Ic7074442b22fc2c11362274e4e390654f3f2400a
(cherry picked from commit d44296e70bb4f1b7fab42d454cef125d3d4479e3)