[3.0 2717]: TOR Scale: Tor Agent crash @ LogicalSwitchEntry::DeleteOvs()

[chhandak]

Observed this crash with scale setup while deleting tor scale config

Backtrace
-----------------
(gdb) bt
#0 0x00007f046e5becc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1 0x00007f046e5c20d8 in __GI_abort () at abort.c:89
#2 0x00007f046e5b7b86 in __assert_fail_base (fmt=0x7f046e708830 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0xfc774c "IsActive()",
    file=file@entry=0xfc78a8 "controller/src/vnsw/agent/ovs_tor_agent/ovsdb_client/logical_switch_ovsdb.cc", line=line@entry=310,
    function=function@entry=0xfc7c20 "void OVSDB::LogicalSwitchEntry::DeleteOvs()") at assert.c:92
#3 0x00007f046e5b7c32 in __GI___assert_fail (assertion=0xfc774c "IsActive()",
    file=0xfc78a8 "controller/src/vnsw/agent/ovs_tor_agent/ovsdb_client/logical_switch_ovsdb.cc", line=310,
    function=0xfc7c20 "void OVSDB::LogicalSwitchEntry::DeleteOvs()") at assert.c:101
#4 0x0000000000a76091 in OVSDB::LogicalSwitchEntry::DeleteOvs() ()
#5 0x0000000000a79cd5 in OVSDB::LogicalSwitchEntry::UnresolvedReference() ()
#6 0x0000000000b643db in KSyncSM_Change(KSyncObject*, KSyncEntry*) ()
#7 0x0000000000b64ed5 in KSyncObject::NotifyEvent(KSyncEntry*, KSyncEntry::KSyncEvent) ()
#8 0x0000000000b663c1 in KSyncDBObject::Notify(DBTablePartBase*, DBEntryBase*) ()
#9 0x0000000000e46bca in DBTableBase::RunNotify(DBTablePartBase*, DBEntryBase*) ()
#10 0x0000000000e492b8 in DBTablePartBase::RunNotify() ()
#11 0x0000000000e4549d in DBPartition::QueueRunner::Run() ()
#12 0x0000000000f5686c in TaskImpl::execute() ()
#13 0x00007f046f18db3a in ?? () from /usr/lib/libtbb.so.2
#14 0x00007f046f189816 in ?? () from /usr/lib/libtbb.so.2
#15 0x00007f046f188f4b in ?? () from /usr/lib/libtbb.so.2
#16 0x00007f046f1850ff in ?? () from /usr/lib/libtbb.so.2
#17 0x00007f046f1852f9 in ?? () from /usr/lib/libtbb.so.2
#18 0x00007f046f3a9182 in start_thread (arg=0x7f046603e700) at pthread_create.c:312
#19 0x00007f046e68247d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

[chhandak (chhandak)]

Logs saved at http://mayamruga.englab.juniper.net/bugs/1550499

[Prabhjot Singh Sethi (prabhjot)]

issues happens while re-activating a deleted entry, and acquiring VxLan ID fails.

During this state it tries to delete OVS entry while the entry is not yet marked active and results in assertion

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18722
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18733
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18722
Committed: http://github.org/Juniper/contrail-controller/commit/894005d5523cc57ef69e8586bc96316757bb6c21
Submitter: Zuul
Branch: master

commit 894005d5523cc57ef69e8586bc96316757bb6c21
Author: Prabhjot Singh Sethi <email address hidden>
Date: Thu Mar 24 11:15:42 2016 +0530

Fix ToR-Agent crash for VxLan Acquire failure

Issue:
------
if VxLan Acquire for a renewed logical switch entry fails
while trying to delete and release previously allocated
VxLan ID it fails on checking for entry being active,
since this check is happening inline in Add/Change
processing where state of the entry was not yet updated
and results in assertion

Fix:
----
pass a vraiable indicating Add/Change in process to skipp
assertion check, which will otherwise will cause false
failure.

Closes-Bug: 1550499
Change-Id: Ief50ca8283c03507b81702218babd16dc8b9c4d6

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18733
Committed: http://github.org/Juniper/contrail-controller/commit/04faf02882dbe03ceaab50983cdbc5b77cde9f27
Submitter: Zuul
Branch: R3.0

commit 04faf02882dbe03ceaab50983cdbc5b77cde9f27
Author: Prabhjot Singh Sethi <email address hidden>
Date: Thu Mar 24 11:15:42 2016 +0530

Fix ToR-Agent crash for VxLan Acquire failure

Issue:
------
if VxLan Acquire for a renewed logical switch entry fails
while trying to delete and release previously allocated
VxLan ID it fails on checking for entry being active,
since this check is happening inline in Add/Change
processing where state of the entry was not yet updated
and results in assertion

Fix:
----
pass a vraiable indicating Add/Change in process to skipp
assertion check, which will otherwise will cause false
failure.

Closes-Bug: 1550499
Change-Id: Ief50ca8283c03507b81702218babd16dc8b9c4d6
(cherry picked from commit 894005d5523cc57ef69e8586bc96316757bb6c21)