Healthcheck: vrouter crash with probe_type HTTP

[Senthilnathan Murugappan]

Using HTTP probes agent continuously crashes.

Build:3.0.0.0-2715 kilo
corefile will be copied to /cs-shared/bugs/1548702

service_health_check_properties: {
enabled: true,
delay: 5,
expected_codes: null,
max_retries: 5,
http_method: null,
timeout: 5,
url_path: null,
monitor_type: "HTTP"
},

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/bin/contrail-vrouter-agent'.
Program terminated with signal SIGABRT, Aborted.
#0 0x00007f51481c8cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) frame 4
#4 0x000000000117dd63 in TaskImpl::execute (this=<optimized out>) at controller/src/base/task.cc:276
276 controller/src/base/task.cc: No such file or directory.
(gdb) bt
#0 0x00007f51481c8cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1 0x00007f51481cc0d8 in __GI_abort () at abort.c:89
#2 0x00007f51481c1b86 in __assert_fail_base (fmt=0x7f5148312830 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x11cfeb5 "0",
    file=file@entry=0x12c4c20 "controller/src/base/task.cc", line=line@entry=276,
    function=function@entry=0x12c6340 <TaskImpl::execute()::__PRETTY_FUNCTION__> "virtual tbb::task* TaskImpl::execute()") at assert.c:92
#3 0x00007f51481c1c32 in __GI___assert_fail (assertion=0x11cfeb5 "0", file=0x12c4c20 "controller/src/base/task.cc", line=276,
    function=0x12c6340 <TaskImpl::execute()::__PRETTY_FUNCTION__> "virtual tbb::task* TaskImpl::execute()") at assert.c:101
#4 0x000000000117dd63 in TaskImpl::execute (this=<optimized out>) at controller/src/base/task.cc:276
#5 0x00007f5148d97b3a in ?? () from /usr/lib/libtbb.so.2
#6 0x00007f5148d93816 in ?? () from /usr/lib/libtbb.so.2
#7 0x00007f5148d92f4b in ?? () from /usr/lib/libtbb.so.2
#8 0x00007f5148d8f0ff in ?? () from /usr/lib/libtbb.so.2
#9 0x00007f5148d8f2f9 in ?? () from /usr/lib/libtbb.so.2
#10 0x00007f5148fb3182 in start_thread (arg=0x7f5117afe700) at pthread_create.c:312
#11 0x00007f514828c47d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb) p e

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17653
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17654
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17654
Committed: http://github.org/Juniper/contrail-controller/commit/dc9c5e98358001e9d39444a67cf2593b4e2245f9
Submitter: Zuul
Branch: R3.0

commit dc9c5e98358001e9d39444a67cf2593b4e2245f9
Author: Prabhjot Singh Sethi <email address hidden>
Date: Tue Feb 23 19:47:30 2016 +0530

Fix handling empty url string for Health Check

Issue:
------
when url string is empty http parser does not seems to
return error and urldata being uninitialised cause
invalid length access in string.

Fix:
----
skip url parsing if url path is empty, this will allow
health check to fallback default to
"http:://<vmi-instance-ip>"

Closes-Bug:1548702
Change-Id: Iba608d01fa89656a7b902ca4781331ca60ac9789
(cherry picked from commit 60ecf03c6d710c79173b83c6afbbfc21bda68e64)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17653
Committed: http://github.org/Juniper/contrail-controller/commit/60ecf03c6d710c79173b83c6afbbfc21bda68e64
Submitter: Zuul
Branch: master

commit 60ecf03c6d710c79173b83c6afbbfc21bda68e64
Author: Prabhjot Singh Sethi <email address hidden>
Date: Tue Feb 23 19:47:30 2016 +0530

Fix handling empty url string for Health Check

Issue:
------
when url string is empty http parser does not seems to
return error and urldata being uninitialised cause
invalid length access in string.

Fix:
----
skip url parsing if url path is empty, this will allow
health check to fallback default to
"http:://<vmi-instance-ip>"

Change-Id: Iba608d01fa89656a7b902ca4781331ca60ac9789
Closes-Bug:1548702