Sandesh auto-generated header files are not self contained

Bug #1543758 reported by Nischal Sheth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Low
mkheni

Bug Description

For example, rtarget_group.cc which includes bgp_peer_types.h does not
compile unless the following files are included prior to it.

#include "sandesh/sandesh_types.h"
#include "sandesh/sandesh.h"
#include "sandesh/sandesh_trace.h"
#include "bgp/bgp_peer_types.h"
#include "bgp/bgp_table.h"
#include "bgp/rtarget/rtarget_route.h"

Tags: analytics base
Nischal Sheth (nsheth)
summary: - Sandesh auto-generated files are not self contained
+ Sandesh auto-generated header files are not self contained
description: updated
Raj Reddy (rajreddy)
tags: added: analytics
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/29981
Submitter: mkheni (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/29981
Committed: http://github.org/Juniper/contrail-sandesh/commit/e2db9a50a161b2a419959eadb0636369186fd8c4
Submitter: Zuul (<email address hidden>)
Branch: master

commit e2db9a50a161b2a419959eadb0636369186fd8c4
Author: mkheni <email address hidden>
Date: Thu Mar 30 11:40:48 2017 -0700

Made Sandesh auto-generated header files self contained.

Sandesh auto-generated header files were not self-contained. for example, rtarget_group.cc which includes bgp_peer_types.h does not
compile unless the following files are included prior to it.

Added code to include these files in all auto-generated header files to solve the issue.

Change-Id: I6d5911a3fe304cd44c21bba4e98b3c85b0725be1
Partial-Bug: #1543758

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/30270
Submitter: mkheni (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/30270
Committed: http://github.com/Juniper/contrail-controller/commit/1d8f306ce7bcddf10d6317c31e6373aa1958f52a
Submitter: Zuul (<email address hidden>)
Branch: master

commit 1d8f306ce7bcddf10d6317c31e6373aa1958f52a
Author: mkheni <email address hidden>
Date: Sat Apr 8 18:46:30 2017 -0700

Made Sandesh auto-generated header files self contained.

Sandesh auto-generated header files were not self-contained. for example, rtarget_group.cc which includes bgp_peer_types.h does not
compile unless the following files are included prior to it.

Added code to include these files in all auto-generated header files to solve the issue. And Hence, there is no need to include them twice.

Change-Id: I54e04871cee1724a9437f6640b03ffdcc7ddd547
Closes-Bug: #1543758

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.0

Review in progress for https://review.opencontrail.org/31206
Submitter: mkheni (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/31552
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/31552
Committed: http://github.com/Juniper/contrail-controller/commit/c19653f33c27467cfadf4498ef2f6ab9a9150de2
Submitter: Zuul (<email address hidden>)
Branch: master

commit c19653f33c27467cfadf4498ef2f6ab9a9150de2
Author: Nischal Sheth <email address hidden>
Date: Sun May 14 20:03:20 2017 -0700

Remove includes for sandesh files from bgp_show_handler.h

Change-Id: I6f902eb812d84b49ae74a839eb928f4a98f3bd43
Closes-Bug: 1543758

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.