lbaasv2: observed multiple IIP refs to right vmis

[Senthilnathan Murugappan]

Version: 3.0-2698 kilo build on ubuntu-1404

After few create and delete of pool, member and listeners observed that the right vmis had two IIP refs and both the IIPs were valid and the master vip_port didnt have IIP associated with it.
Also even after deleting the LB the Service Instance and the derived objects (VM/VMI/IIP) wasnt deleted.

{
    "virtual-machine-interface": {
        "display_name": "default-domain__admin__2f40a4f4-950c-498c-be0c-68a6c50a91a7__2__right__1",
        "fq_name": [
            "default-domain",
            "admin",
            "default-domain__admin__2f40a4f4-950c-498c-be0c-68a6c50a91a7__2__right__1"
        ],
        "href": "http://10.84.7.41:8082/virtual-machine-interface/fc091477-75d3-4313-8d34-f016ab7bb2de",
        "id_perms": {
            "created": "2016-01-16T23:30:33.799047",
            "creator": null,
            "description": null,
            "enable": true,
            "last_modified": "2016-01-16T23:30:33.831820",
            "permissions": {
                "group": "cloud-admin-group",
                "group_access": 7,
                "other_access": 7,
                "owner": "cloud-admin",
                "owner_access": 7
            },
            "user_visible": false,
            "uuid": {
                "uuid_lslong": 10175021438293750494,
                "uuid_mslong": 18161069475658679059
            }
        },
        "instance_ip_back_refs": [
            {
                "attr": null,
                "href": "http://10.84.7.41:8082/instance-ip/3bad362e-1809-4b02-88a6-e6c9bc680b9c",
                "to": [
                    "2f40a4f4-950c-498c-be0c-68a6c50a91a7"
                ],
                "uuid": "3bad362e-1809-4b02-88a6-e6c9bc680b9c"
            },
            {
                "attr": null,
                "href": "http://10.84.7.41:8082/instance-ip/59691804-b546-4cf2-962e-e524e84eed5d",
                "to": [
                    "default-domain__admin__2f40a4f4-950c-498c-be0c-68a6c50a91a7-right"
                ],
                "uuid": "59691804-b546-4cf2-962e-e524e84eed5d"
            }
        ],
        "name": "default-domain__admin__2f40a4f4-950c-498c-be0c-68a6c50a91a7__2__right__1",
        "parent_href": "http://10.84.7.41:8082/project/b105460e-bf4f-4878-af46-f09a9291dd8d",
        "parent_type": "project",
        "parent_uuid": "b105460e-bf4f-4878-af46-f09a9291dd8d",
        "perms2": {
            "global_access": 0,
            "owner": null,
            "owner_access": 7,
            "share": []
        },
        "routing_instance_refs": [
            {
                "attr": {
                    "direction": "both",
                    "dst_mac": null,
                    "ipv6_service_chain_address": null,
                    "mpls_label": null,
                    "protocol": null,
                    "service_chain_address": null,
                    "src_mac": null,
                    "vlan_tag": null
                },
                "href": "http://10.84.7.41:8082/routing-instance/d63ef8d3-af27-4992-ab7b-ad767e83ebaa",
                "to": [
                    "default-domain",
                    "admin",
                    "lbaasnet1",
                    "lbaasnet1"
                ],
                "uuid": "d63ef8d3-af27-4992-ab7b-ad767e83ebaa"
            }
        ],
        "security_group_refs": [
            {
                "attr": null,
                "href": "http://10.84.7.41:8082/security-group/9074858f-0fe2-49f8-a8ac-96cbe48030fd",
                "to": [
                    "default-domain",
                    "admin",
                    "default"
                ],
                "uuid": "9074858f-0fe2-49f8-a8ac-96cbe48030fd"
            }
        ],
        "uuid": "fc091477-75d3-4313-8d34-f016ab7bb2de",
        "virtual_machine_interface_mac_addresses": {
            "mac_address": [
                "02:3b:ad:36:2e:18"
            ]
        },
        "virtual_machine_interface_properties": {
            "ecmp_hashing_include_fields": null,
            "interface_mirror": null,
            "local_preference": 100,
            "service_interface_type": "right",
            "sub_interface_vlan_tag": null
        },
        "virtual_machine_refs": [
            {
                "attr": null,
                "href": "http://10.84.7.41:8082/virtual-machine/96bff47d-630f-4702-b7a5-44bbbbc11e5e",
                "to": [
                    "default-domain__admin__2f40a4f4-950c-498c-be0c-68a6c50a91a7__2"
                ],
                "uuid": "96bff47d-630f-4702-b7a5-44bbbbc11e5e"
            }
        ],
        "virtual_network_refs": [
            {
                "attr": null,
                "href": "http://10.84.7.41:8082/virtual-network/b66e6274-e367-4bfa-9199-38e03be95010",
                "to": [
                    "default-domain",
                    "admin",
                    "lbaasnet1"
                ],
                "uuid": "b66e6274-e367-4bfa-9199-38e03be95010"
            }
        ]
    }
}

{
    "instance-ip": {
        "display_name": "2f40a4f4-950c-498c-be0c-68a6c50a91a7",
        "fq_name": [
            "2f40a4f4-950c-498c-be0c-68a6c50a91a7"
        ],
        "href": "http://10.84.7.41:8082/instance-ip/3bad362e-1809-4b02-88a6-e6c9bc680b9c",
        "id_perms": {
            "created": "2016-01-16T01:17:55.931747",
            "creator": null,
            "description": null,
            "enable": true,
            "last_modified": "2016-01-25T23:16:41.087170",
            "permissions": {
                "group": "cloud-admin-group",
                "group_access": 7,
                "other_access": 7,
                "owner": "cloud-admin",
                "owner_access": 7
            },
            "user_visible": true,
            "uuid": {
                "uuid_lslong": 9846811389415918492,
                "uuid_mslong": 4300152790808349442
            }
        },
        "instance_ip_address": "1.1.1.3",
        "instance_ip_mode": "active-standby",
        "name": "2f40a4f4-950c-498c-be0c-68a6c50a91a7",
        "perms2": {
            "global_access": 0,
            "owner": null,
            "owner_access": 7,
            "share": []
        },
        "uuid": "3bad362e-1809-4b02-88a6-e6c9bc680b9c",
        "virtual_machine_interface_refs": [
            {
                "attr": null,
                "href": "http://10.84.7.41:8082/virtual-machine-interface/fc091477-75d3-4313-8d34-f016ab7bb2de",
                "to": [
                    "default-domain",
                    "admin",
                    "default-domain__admin__2f40a4f4-950c-498c-be0c-68a6c50a91a7__2__right__1"
                ],
                "uuid": "fc091477-75d3-4313-8d34-f016ab7bb2de"
            },
            {
                "attr": null,
                "href": "http://10.84.7.41:8082/virtual-machine-interface/fcb36d36-e3e9-4043-98a9-e107f6d32820",
                "to": [
                    "default-domain",
                    "admin",
                    "default-domain__admin__2f40a4f4-950c-498c-be0c-68a6c50a91a7__1__right__1"
                ],
                "uuid": "fcb36d36-e3e9-4043-98a9-e107f6d32820"
            }
        ],
        "virtual_network_refs": [
            {
                "attr": null,
                "href": "http://10.84.7.41:8082/virtual-network/b66e6274-e367-4bfa-9199-38e03be95010",
                "to": [
                    "default-domain",
                    "admin",
                    "lbaasnet1"
                ],
                "uuid": "b66e6274-e367-4bfa-9199-38e03be95010"
            }
        ]
    }
}

Did restart to recover the setup and observed the below.
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/svc_monitor/svc_monitor.py", line 618, in _create_service_instance
    self.netns_manager.create_service(st, si)
  File "/usr/lib/python2.7/dist-packages/svc_monitor/instance_manager.py", line 699, in create_service
    vm = self._check_create_netns_vm(index, si, st, vm_list[index])
  File "/usr/lib/python2.7/dist-packages/svc_monitor/instance_manager.py", line 421, in _check_create_netns_vm
    self._agent_manager.pre_create_service_vm(instance_index, si, st, vm)
  File "/usr/lib/python2.7/dist-packages/svc_monitor/agent_manager.py", line 31, in pre_create_service_vm
    agent.pre_create_service_vm(instance_index, si, st, vm)
  File "/usr/lib/python2.7/dist-packages/svc_monitor/loadbalancer_agent.py", line 40, in pre_create_service_vm
    for iip_id in vmi.instance_ips:
AttributeError: 'NoneType' object has no attribute 'instance_ips'

[OpenContrail Admin (ci-admin-f)]

bug update...

[Yuvaraja Mariappan (ymariappan)]

pls check it in the mainline.

Thanks,
Yuvaraja