healthcheck: url_path isnt passed on to the healthcheck script

Bug #1533606 reported by Senthilnathan Murugappan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
High
Prabhjot Singh Sethi

Bug Description

With below healthcheck prop observed that the healthcheck script wasnt called with uri set. Also the sandesh resp from the agent introspect doesnt show the uri_path

service_health_check_properties: {
enabled: true,
delay: 5,
expected_codes: null,
max_retries: 5,
http_method: null,
timeout: 5,
url_path: "http://62.66.136.3/test/",
monitor_type: "HTTP"
},

2016-01-13 Wed 01:35:50:606.257 PST a2s42 [Thread 140350705886976, Pid 7597]: NetNS run command: /opt/contrail/utils/contrail_vrouter_agent_health_check.py -m HTTP -d 169.254.31.244 -t 5 -r 5 -i 5

Revision history for this message
Prabhjot Singh Sethi (prabhjot) wrote :

issue due to same variable name used in the scope causing url path remaining unset

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/16266
Submitter: Prabhjot Singh Sethi (<email address hidden>)

tags: added: blocker
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/16266
Committed: http://github.org/Juniper/contrail-controller/commit/c12c7466deb0a4230f68a4667eaab9d3011b6d56
Submitter: Zuul
Branch: master

commit c12c7466deb0a4230f68a4667eaab9d3011b6d56
Author: Prabhjot Singh Sethi <email address hidden>
Date: Mon Feb 1 16:12:02 2016 +0530

Fix Health Check HTTP url parsing

Issue:
------
usage of same variable name in local scope caused the
parsed value being destroyed with the scope, causing
url path to remain unset

Fix:
----
use http_parser to parse url provided for HTTP method,
where in case of error agent fall backs to use
http://<interface_primary_ip>/ as health check url

Closes-Bug: 1533606
Closes-Bug: 1533608
Related-Bug: 1530539
Change-Id: I60773eaef30b10008c693254de51933553b9561f

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.