[R2.22.115] Tor Agent is not getting pnroviosned with server manager

[chhandak]

With build R2.22.115 Toragent is not provisioned on target node..No relevant configuration file is getting created. Tried without TSN HA.

Further Debugging input from dev
------------------------------------------------------
There has been some failures.

One issue is that "service contrail-tor-agent-1 restart is not working. Because of this, puppet is not able to start tor-agents. I tried starting tor agents manually, it was started. I observed '/etc/init/‘ has no files for tor agent. I am not sure if these are required. Is this a difference in 12.04 and 14.04 ?

Another is failure in creation of cacert:
Dec 10 20:57:40 nodec63 puppet-agent[2195]: (/Stage[post]/Contrail::Provision_complete/Contrail::Lib::Report_status[post_provision_completed]/Exec[contrail-status-post_provision_completed]) Dependency File[tor-agent-ssl-cacert] has failures: true
Dec 10 20:57:40 nodec63 puppet-agent[2195]: (/Stage[post]/Contrail::Provision_complete/Contrail::Lib::Report_status[post_provision_completed]/Exec[contrail-status-post_provision_completed]) Skipping because of failed dependencies
Dec 10 20:57:40 nodec63 puppet-agent[2195]: (/Stage[post]/Contrail::Provision_complete/Exec[do-reboot-server]) Dependency File[tor-agent-ssl-cacert] has failures: true
Dec 10 20:57:40 nodec63 puppet-agent[2195]: (/Stage[post]/Contrail::Provision_complete/Exec[do-reboot-server]) Skipping because of failed dependencies
Dec 10 20:57:40 nodec63 puppet-agent[2195]: Finished catalog run in 6.13 seconds

And other issue is to it must have been failed status, instead of provision_completed status. Got the root cause for above problem. Currently it is trying to create a cacert to the target node. But cacert is not required in current case, so cacert creation should be in a condition and toragent_completed should be also depend on cacert creation. For now, work around for this is to just create a file name cacert.pem at /etc/contrail_smgr/puppet/ssl/ (create directory as well)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16561
Submitter: Dheeraj Gautam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16561
Committed: http://github.org/Juniper/contrail-puppet/commit/065ec8a360bd9dee49693431fc7fb7e933824999
Submitter: Zuul
Branch: master

commit 065ec8a360bd9dee49693431fc7fb7e933824999
Author: Dheeraj Gautam <email address hidden>
Date: Wed Jan 27 10:43:01 2016 -0800

SM-TOR: missed file to check-in

Change-Id: I6cb3596d87e8ca5466eba4b43b1205a3fb2a6625
Closes-bug: #1525370

[Dheeraj Gautam (dgautam)]

Closing the R2.20 scope as this has been fixed in newer releases