Agent crash at KSyncIoContext::GetKSyncEntry

[Hari Prasad Killi]

Core was generated by `/usr/bin/contrail-vrouter-agent'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00000000018c2aaa in KSyncIoContext::GetKSyncEntry (this=0x0) at controller/src/ksync/ksync_sock.h:132
132 controller/src/ksync/ksync_sock.h: No such file or directory.
(gdb) bt
#0 0x00000000018c2aaa in KSyncIoContext::GetKSyncEntry (this=0x0) at controller/src/ksync/ksync_sock.h:132
#1 0x00000000018c1dd1 in KSyncSandeshContext::FlowMsgHandler (this=0x7f6af8104070, r=0x7f6aac39e190)
    at controller/src/vnsw/agent/vrouter/ksync/sandesh_ksync.cc:67
#2 0x00000000018e4f58 in KSyncBulkSandeshContext::FlowMsgHandler (this=0x7f6a540936d8, req=0x7f6aac39e190) at controller/src/ksync/ksync_sock.cc:1004
#3 0x00000000018a7f9c in vr_flow_req::Process (this=0x7f6aac39e190, context=0x7f6a540936d8)
    at controller/src/vnsw/agent/vrouter/ksync/ksync_flow_memory.cc:350
#4 0x0000000001de7efe in Sandesh::ReceiveBinaryMsgOne (buf=0x7f6aa470f996 "", buf_len=234, error=0x7f6ae9ff65d8, client_context=0x7f6a540936d8)
    at tools/sandesh/library/cpp/sandesh.cc:563
#5 0x00000000018e0465 in DecodeSandeshMessages (buf=0x7f6aa470f996 "", buf_len=234, sandesh_context=0x7f6a540936d8, alignment=4)
    at controller/src/ksync/ksync_sock.cc:167
#6 0x00000000018e4b52 in KSyncBulkSandeshContext::Decoder (this=0x7f6a540936d8, data=0x7f6aa470f978 "", len=264, alignment=4, more=false)
    at controller/src/ksync/ksync_sock.cc:930
#7 0x00000000018e3bb2 in KSyncSockTcp::BulkDecoder (this=0x7f6af8100860, data=0x7f6aa470f960 " \001", bulk_context=0x7f6a540936d8)
    at controller/src/ksync/ksync_sock.cc:732
#8 0x00000000018e1440 in KSyncSock::ProcessKernelData (this=0x7f6af8100860, data=0x7f6aa470f960 " \001") at controller/src/ksync/ksync_sock.cc:323

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/15628
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/15628
Committed: http://github.org/Juniper/contrail-controller/commit/f089ff20e7e18f627c7a12ce5cd9b450b74ea9e1
Submitter: Zuul
Branch: master

commit f089ff20e7e18f627c7a12ce5cd9b450b74ea9e1
Author: Manish Singh <email address hidden>
Date: Sat Dec 5 11:55:14 2015 +0530

Agent crashes at KSyncSandeshContext::FlowMsgHandler

Problem:
KSyncIoContext was NULL. During bulk send both uve and config messages were
stored in same Bulk Sandesh object. When response was received then both
messages were being processed in respective context and in turn iterator was
becoming invalid (e.g. iterator was of type uve for message of type config).

Solution:
Bulk only same context type messages. Moment a different context type is seen
create a new bulk message.

Change-Id: Id26952f986b44649e518f231226d4db10385e7ac
closes-bug: 1523080