Advertise origin vn for each ecmp path in xmpp

Bug #1518034 reported by Nischal Sheth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Wishlist
Nischal Sheth

Bug Description

Current implementation advertises the origin vn as a property of the
route. Some service chaining uses cases require this field for each ecmp
path.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/15653
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/15719
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/15653
Committed: http://github.org/Juniper/contrail-controller/commit/6f2349653e1f050d90ceec198a3e70b5e5ccbdb0
Submitter: Zuul
Branch: master

commit 6f2349653e1f050d90ceec198a3e70b5e5ccbdb0
Author: Nischal Sheth <email address hidden>
Date: Thu Dec 3 15:01:00 2015 -0800

Advertise origin vn for each ecmp path in xmpp

This capability is required for advanced service chaining use cases
where the same route is learnt from 2 or more service chains. An ACL
tells the vRouter which chain to use for given flow.

Temporarily disable xmpp_ecmp_test. Ananth is working on updating it
to properly handle multiple origin vns for a path and not resuse the
same label for in different VRFs.

Highlights:

- Schema channge to add virtual-network to NextHopType
- Move some code from bgp_ribout.h to bgp_ribout.cc
- Get rid of vrf_originated_ field in RibOutAttr
- Encode the origin_vn_index in each NextHop
- An origin_vn_index of 0 says that path is vrf originated
- XmppMessageBuilder translates origin_vn_index to a name
- Sprinkle const in a few places
- Add integration tests to verify new functionality

Change-Id: I72c8aab47ba1ab9141a811a89a93ed22114802e4
Closes-Bug: 1518034

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/15719
Committed: http://github.org/Juniper/contrail-controller/commit/d05fb65127f465917a7de6e5488824ed76a3b9f3
Submitter: Zuul
Branch: master

commit d05fb65127f465917a7de6e5488824ed76a3b9f3
Author: Ananth Suryanarayana <email address hidden>
Date: Wed Dec 9 14:57:07 2015 -0800

Set virtual_network in nexthops and verify them in xmpp_ecmp_test

Also, as the test found out, remove possibility of duplicate next-hops
by retrieving origin_network from the table and encode in RibOutAttr::NextHop
structure, instead of encoding 0.

Change-Id: I333597ae3920abb8af04010bb2620e9599562df5
Closes-Bug: 1518034

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.