schema errors while creating snat instances causing sanity to fail

[Vedamurthy Joshi]

R3.0 Build 2561

test_basic_snat_behavior sanity test failed due to below schema errors.
After correcting these syntax errors ( self.left_vn_str instead of left_vn_str, and self.right_vn_str instead of right_vn_str) , the testcase passed

python -m testtools.run scripts.neutron.test_routers.TestRouterSNAT.test_basic_snat_behavior

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 210, in _vnc_subscribe_callback
    obj = obj_class.locate(obj_fq_name)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/config_db.py", line 97, in locate
    obj = super(DBBaseST, cls).locate(key, *args)
  File "/usr/lib/python2.7/dist-packages/cfgm_common/vnc_db.py", line 59, in locate
    obj = cls(key, *args)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/config_db.py", line 2862, in __init__
    self.update(obj)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/config_db.py", line 2875, in update
    self.add_properties(props)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/config_db.py", line 2935, in add_properties
    networks.add(left_vn_str)
NameError: global name 'left_vn_str' is not defined

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 210, in _vnc_subscribe_callback
    obj = obj_class.locate(obj_fq_name)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/config_db.py", line 97, in locate
    obj = super(DBBaseST, cls).locate(key, *args)
  File "/usr/lib/python2.7/dist-packages/cfgm_common/vnc_db.py", line 59, in locate
    obj = cls(key, *args)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/config_db.py", line 2862, in __init__
    self.update(obj)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/config_db.py", line 2875, in update
    self.add_properties(props)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/config_db.py", line 2939, in add_properties
    networks.add(right_vn_str)
NameError: global name 'right_vn_str' is not defined

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/13949
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/13949
Committed: http://github.org/Juniper/contrail-controller/commit/9427abd05393dc590f38509551415a85cdc11e39
Submitter: Zuul
Branch: master

commit 9427abd05393dc590f38509551415a85cdc11e39
Author: Sachin Bansal <email address hidden>
Date: Mon Sep 21 11:27:41 2015 -0700

add_properties should not return network set

Networks affected as a result of config change are tracked using dependency
tracker. There is no need to track them manually.

Also, for ECMP case, one instance ip could be connected to more than one vmi.
The references should be maintained in a set.

Change-Id: Ib55ab7a96faaff03f5ed08afa7d55d7c18599044
Closes-Bug: 1497877

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14016
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14016
Committed: http://github.org/Juniper/contrail-controller/commit/da4c8ee3b57872d7e11f45c645a78bbfd11bda17
Submitter: Zuul
Branch: R2.22-dev

commit da4c8ee3b57872d7e11f45c645a78bbfd11bda17
Author: Sachin Bansal <email address hidden>
Date: Mon Sep 21 11:27:41 2015 -0700

add_properties should not return network set

Networks affected as a result of config change are tracked using dependency
tracker. There is no need to track them manually.

Also, for ECMP case, one instance ip could be connected to more than one vmi.
The references should be maintained in a set.

Change-Id: Ib55ab7a96faaff03f5ed08afa7d55d7c18599044
Closes-Bug: 1497877
(cherry picked from commit 9427abd05393dc590f38509551415a85cdc11e39)