DHCP vendor specific option should take an array of bytes as input

Bug #1490418 reported by Hari Prasad Killi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Committed
Medium
Hari Prasad Killi
Trunk
Fix Committed
Medium
Hari Prasad Killi

Bug Description

DHCP vendor specific options take a string as input in the current implementation, but as these could be further interpreted, these should be taken as an array of bytes.

Tags: vrouter
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/13430
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13430
Committed: http://github.org/Juniper/contrail-controller/commit/e94f03b25ad0e39b991c4e5365427ddf6405e8f4
Submitter: Zuul
Branch: R2.20

commit e94f03b25ad0e39b991c4e5365427ddf6405e8f4
Author: Hari <email address hidden>
Date: Mon Aug 31 13:49:34 2015 +0530

Change vendor-specific DHCP options input to byte array.

Also, fix byte array processing to take each byte and encode that
value in DHCP response. Updated UTs for this.

Change-Id: Iba3a73f3111e835863c0904f9a1f062e2184979c
closes-bug: 1490418

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/13516
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13516
Committed: http://github.org/Juniper/contrail-controller/commit/fae2a735f9fde5952e1174033d411f90db3c73cb
Submitter: Zuul
Branch: R2.20

commit fae2a735f9fde5952e1174033d411f90db3c73cb
Author: Hari <email address hidden>
Date: Wed Sep 2 18:42:41 2015 +0530

Add dhcp-option-value-bytes to take encoded input.

Added this field to DhcpOptionType in schema, to take input byte by byte
in decimal. When set, this value is copied for the option as is (for
options taking String as input).

Change-Id: I54df34ffc1c72c32a936314b91904520e01e6b7b
closes-bug: 1490418

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/13622
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/13631
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13631
Committed: http://github.org/Juniper/contrail-controller/commit/3522e67b83b0bb02374d47ebd46cd0b8f1870f62
Submitter: Zuul
Branch: R2.20

commit 3522e67b83b0bb02374d47ebd46cd0b8f1870f62
Author: Hari <email address hidden>
Date: Mon Sep 7 14:53:56 2015 +0530

Use dhcp-option-value-bytes also in displaying via neutron.

When the option value in bytes is set, use that while displaying the option
in Neutron.

Change-Id: I0e1538946d16582fc5b9abf48e9090bb3a155c81
closes-bug: 1490418

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/13687
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13622
Committed: http://github.org/Juniper/contrail-controller/commit/9a42ac4322fa60caf12c82f74529f3630a6d5ecf
Submitter: Zuul
Branch: master

commit 9a42ac4322fa60caf12c82f74529f3630a6d5ecf
Author: Hari <email address hidden>
Date: Mon Aug 31 13:49:34 2015 +0530

Add dhcp-option-value-bytes to take encoded input.

Added this field to DhcpOptionType in schema, to take input byte by byte
in decimal. When set, this value is copied for the option as is (for
options taking String as input).

Also, fix byte array processing to take each byte and encode that
value in DHCP response. Updated UTs for this.

Change-Id: I54df34ffc1c72c32a936314b91904520e01e6b7b
closes-bug: 1490418
(cherry picked from commit e94f03b25ad0e39b991c4e5365427ddf6405e8f4)
(cherry picked from commit fae2a735f9fde5952e1174033d411f90db3c73cb)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/13687
Committed: http://github.org/Juniper/contrail-controller/commit/1e19b6229cf50a858d63e7f72fed6703ea1d6100
Submitter: Zuul
Branch: master

commit 1e19b6229cf50a858d63e7f72fed6703ea1d6100
Author: Hari <email address hidden>
Date: Mon Sep 7 14:53:56 2015 +0530

Use dhcp-option-value-bytes also in displaying via neutron.

When the option value in bytes is set, use that while displaying the option
in Neutron.

Change-Id: I0e1538946d16582fc5b9abf48e9090bb3a155c81
closes-bug: 1490418
(cherry picked from commit 3522e67b83b0bb02374d47ebd46cd0b8f1870f62)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev

Review in progress for https://review.opencontrail.org/13927
Submitter: Vinay Vithal Mahuli (<email address hidden>)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.