With R2.20 74 onwards, on CentOS 6.5, discovery fails

Bug #1480883 reported by Vedamurthy Joshi
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Committed
High
Deepinder Setia
Trunk
Fix Committed
High
Deepinder Setia

Bug Description

R2.20 74 or 75, Centos 6.5

Looks like list-comprehension issue with python 2.6

http://anamika.englab.juniper.net:8080/job/centos65_icehouse_Multi_Node_Sanity/375/

This commit caused the breakage :
https://github.com/Juniper/contrail-controller/commit/07e421a4d7ac419dc2cc64cf7ee6137cc9249dc5

Traceback (most recent call last):
  File "/usr/bin/contrail-discovery", line 9, in <module>
    load_entry_point('discovery==0.1dev', 'console_scripts', 'contrail-discovery')()
  File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 299, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 2229, in load_entry_point
    return ep.load()
  File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 1948, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "/usr/lib/python2.6/site-packages/discovery/disc_server.py", line 653
    lb_list = {item['service_id']:(item['in_use']-int(avg_per_pub)) for item in pubs_active if item['in_use'] > int(1.05*avg_per_pub)}
                                                                      ^
SyntaxError: invalid syntax

tags: added: blocker
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12814
Submitter: Deepinder Setia (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12814
Committed: http://github.org/Juniper/contrail-controller/commit/f95df9d18b314bd08108ab6ce3f6b753711579e0
Submitter: Zuul
Branch: R2.20

commit f95df9d18b314bd08108ab6ce3f6b753711579e0
Author: Deepinder Setia <email address hidden>
Date: Mon Aug 3 13:17:05 2015 -0700

bug 1480883: get rid of dict comprehension and build the dict using for loop

Change-Id: Ibc01e92c4a7191ef082af3b2756bbc43a9b156be

Revision history for this message
Pavana (pavanap) wrote :

Happening on mainline as well, observed on 3.0 2638. Can the commit be extended to master too?
Bug #1488020

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev

Review in progress for https://review.opencontrail.org/13927
Submitter: Vinay Vithal Mahuli (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/17295
Submitter: Deepinder Setia (<email address hidden>)

tags: removed: blocker
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.