R2.20[49]: device manager failed to start

[Jeba Paulaiyan]

R2.20 [build 49]

2015-06-12 15:05:46:870263: [root@172.16.70.2] out: == Contrail Config ==
2015-06-12 15:05:46:870444: [root@172.16.70.2] out: supervisor-config: active
2015-06-12 15:05:46:902739: [root@172.16.70.2] out: contrail-api:0 active
2015-06-12 15:05:47:018888: [root@172.16.70.2] out: contrail-config-nodemgr active
2015-06-12 15:05:47:034872: [root@172.16.70.2] out: contrail-device-manager failed
2015-06-12 15:05:47:035104: [root@172.16.70.2] out: contrail-discovery:0 active
2015-06-12 15:05:47:035609: [root@172.16.70.2] out: contrail-schema backup
2015-06-12 15:05:47:035842: [root@172.16.70.2] out: contrail-svc-monitor backup
2015-06-12 15:05:47:036627: [root@172.16.70.2] out: ifmap active
2015-06-12 15:05:47:036855: [root@172.16.70.2] out:

 /usr/lib/python2.7/dist-packages/device_manager/db.py in uve_send(self=<device_manager.db.PhysicalRouterDM object>, deleted=False)
  278 return
  279
  280 commit_stats = self.config_manager.get_commit_stats()
  281
  282 if commit_stats['netconf_enabled'] is True:
commit_stats undefined
self = <device_manager.db.PhysicalRouterDM object>
self.config_manager = <device_manager.physical_router_config.PhysicalRouterConfig object>
self.config_manager.get_commit_stats = <bound method PhysicalRouterConfig.get_commit_st...sical_router_config.PhysicalRouterConfig object>>
<type 'exceptions.TypeError'>: get_commit_stats() takes no arguments (1 given)
    __class__ = <type 'exceptions.TypeError'>
    __delattr__ = <method-wrapper '__delattr__' of exceptions.TypeError object>
    __dict__ = {}
    __doc__ = 'Inappropriate argument type.'
    __format__ = <built-in method __format__ of exceptions.TypeError object>
    __getattribute__ = <method-wrapper '__getattribute__' of exceptions.TypeError object>
    __getitem__ = <method-wrapper '__getitem__' of exceptions.TypeError object>
    __getslice__ = <method-wrapper '__getslice__' of exceptions.TypeError object>
    __hash__ = <method-wrapper '__hash__' of exceptions.TypeError object>
    __init__ = <method-wrapper '__init__' of exceptions.TypeError object>
    __new__ = <built-in method __new__ of type object>
    __reduce__ = <built-in method __reduce__ of exceptions.TypeError object>
    __reduce_ex__ = <built-in method __reduce_ex__ of exceptions.TypeError object>
    __repr__ = <method-wrapper '__repr__' of exceptions.TypeError object>
    __setattr__ = <method-wrapper '__setattr__' of exceptions.TypeError object>
    __setstate__ = <built-in method __setstate__ of exceptions.TypeError object>
    __sizeof__ = <built-in method __sizeof__ of exceptions.TypeError object>
    __str__ = <method-wrapper '__str__' of exceptions.TypeError object>
    __subclasshook__ = <built-in method __subclasshook__ of type object>
    __unicode__ = <built-in method __unicode__ of exceptions.TypeError object>
    args = ('get_commit_stats() takes no arguments (1 given)',)
    message = 'get_commit_stats() takes no arguments (1 given)'

The above is a description of an error in a Python program. Here is
the original traceback:

Traceback (most recent call last):
  File "/usr/bin/contrail-device-manager", line 9, in <module>
    load_entry_point('device-manager==0.1dev', 'console_scripts', 'contrail-device-manager')()
  File "/usr/lib/python2.7/dist-packages/device_manager/device_manager.py", line 528, in server_main
    main()
  File "/usr/lib/python2.7/dist-packages/device_manager/device_manager.py", line 517, in main
    args)
  File "/usr/lib/python2.7/dist-packages/cfgm_common/zkclient.py", line 291, in master_election
    self._election.run(self._zk_election_callback, func, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/kazoo/recipe/election.py", line 48, in run
    func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/cfgm_common/zkclient.py", line 283, in _zk_election_callback
    func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/device_manager/device_manager.py", line 522, in run_device_manager
    device_manager = DeviceManager(args)
  File "/usr/lib/python2.7/dist-packages/device_manager/device_manager.py", line 217, in __init__
    pr = PhysicalRouterDM.locate(uuid)
  File "/usr/lib/python2.7/dist-packages/cfgm_common/vnc_db.py", line 55, in locate
    cls._dict[key] = cls(key, *args)
  File "/usr/lib/python2.7/dist-packages/device_manager/db.py", line 104, in __init__
    self.uve_send()
  File "/usr/lib/python2.7/dist-packages/device_manager/db.py", line 280, in uve_send
    commit_stats = self.config_manager.get_commit_stats()
TypeError: get_commit_stats() takes no arguments (1 given)

[Jeba Paulaiyan (jebap)]

Testbed: Config nodes: (upgraded from build 39 to 49)

alias c12="ssh root@10.87.24.33"
alias c13="ssh root@10.87.24.34"
alias c14="ssh root@10.87.24.37"

build host: 10.87.26.230

logs located in /opt/contrail/contrail-fabric-utils

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11533
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11534
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/11534
Committed: http://github.org/Juniper/contrail-controller/commit/3e81f8191a7cf3102ce0d87e9eee23a2fe83e907
Submitter: Zuul
Branch: master

commit 3e81f8191a7cf3102ce0d87e9eee23a2fe83e907
Author: sbalineni <email address hidden>
Date: Thu Jun 11 18:38:33 2015 -0700

l3 vrf and l2 evpn vrf config both need to be configured

Currently, DM configures only one vrf for a a virtual network either l2 evpn or
l3 vrf config but not both depending on the vxlan vni identifier.

It must configure both for a private network.
For a public network, only l3 vrf config is required.
import-export statment is not required for l2 vrf.
UT tests for these modifications are tracked in https://bugs.launchpad.net/juniperopenstack/+bug/1464792

Fixed the issue - self paramter is minning in get_commit_stats()

Change-Id: I7821aa535622df9ce7ee780fd6a44abc680aaec8
Closes-Bug: #1464446
Closes-Bug: #1464786

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/11533
Committed: http://github.org/Juniper/contrail-controller/commit/008791a80e3e483f720e50ac3198f0c44aa71738
Submitter: Zuul
Branch: R2.20

commit 008791a80e3e483f720e50ac3198f0c44aa71738
Author: sbalineni <email address hidden>
Date: Thu Jun 11 18:32:15 2015 -0700

l3 vrf and l2 evpn vrf config both need to be configured

Currently, DM configures only one vrf for a a virtual network either l2 evpn or
l3 vrf config but not both depending on the vxlan vni identifier.

It must configure both for a private network.
For a public network, only l3 vrf config is required.
import-export statment is not required for l2 vrf.
UT tests for these modifications are tracked in https://bugs.launchpad.net/juniperopenstack/+bug/1464792

Fixed the issue - self paramter is minning in get_commit_stats()

Closes-Bug: #1464446
Closes-Bug: #1464786

Change-Id: I6eb9763342631ba6a9235cc4145ea180604e5c8a