Remove assert unless absolutely needed so service is resilient

Bug #1456193 reported by Hampapur Ajay on 2015-05-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R1.1
Won't Fix
High
Nischal Sheth
R2.0
Fix Committed
High
Nischal Sheth
R2.1
Fix Committed
High
Nischal Sheth
R2.20
Fix Committed
High
Nischal Sheth
Trunk
Fix Committed
High
Nischal Sheth

Bug Description

In a case where routing-instance->static_route_entries->next_hop was 'null', there was an assert in contrail-control. This assert always occurred on startup and in effect service was unavailable. It would have been preferable to log this incorrect data and have the service be resilient. Other cases of such un-needed assert should be converted to log + continue.

tags: added: contrail-control
Nischal Sheth (nsheth) on 2015-05-18
Changed in juniperopenstack:
assignee: nobody → Nischal Sheth (nsheth)
tags: added: sym

Review in progress for https://review.opencontrail.org/10514
Submitter: Nischal Sheth (<email address hidden>)

Review in progress for https://review.opencontrail.org/10515
Submitter: Nischal Sheth (<email address hidden>)

Review in progress for https://review.opencontrail.org/10516
Submitter: Nischal Sheth (<email address hidden>)

Review in progress for https://review.opencontrail.org/10517
Submitter: Nischal Sheth (<email address hidden>)

Reviewed: https://review.opencontrail.org/10515
Committed: http://github.org/Juniper/contrail-controller/commit/04424af92ff86beff005a079cf1f46c64ec8918e
Submitter: Zuul
Branch: R2.0

commit 04424af92ff86beff005a079cf1f46c64ec8918e
Author: Nischal Sheth <email address hidden>
Date: Mon May 18 11:07:04 2015 -0700

Improve error handling for static route config parsing

Do not assert when we encounter parse errors in prefixes,
nexthops and route targets.
Add tests to cover the above scenarios.

Change-Id: Ia0fb3404dafe734ef4ad6e13885d53766aa6d95b
Partial-Bug: 1456193

Review in progress for https://review.opencontrail.org/10561
Submitter: Nischal Sheth (<email address hidden>)

Review in progress for https://review.opencontrail.org/10628
Submitter: Nischal Sheth (<email address hidden>)

Review in progress for https://review.opencontrail.org/10630
Submitter: Nischal Sheth (<email address hidden>)

Review in progress for https://review.opencontrail.org/10631
Submitter: Nischal Sheth (<email address hidden>)

Review in progress for https://review.opencontrail.org/10633
Submitter: Nischal Sheth (<email address hidden>)

Reviewed: https://review.opencontrail.org/10630
Committed: http://github.org/Juniper/contrail-controller/commit/614cdf543cc744dfc7c365629bce7569fe20bed3
Submitter: Zuul
Branch: R2.20

commit 614cdf543cc744dfc7c365629bce7569fe20bed3
Author: Nischal Sheth <email address hidden>
Date: Wed May 20 18:05:21 2015 -0700

Get rid of a few unnecessary asserts

Change-Id: I9e165d91c5c5485e908f44bee41688c52899c2d2
Partial-Bug: 1456193

Reviewed: https://review.opencontrail.org/10514
Committed: http://github.org/Juniper/contrail-controller/commit/10e2976d18558cb6d110a0df740d413e40b05884
Submitter: Zuul
Branch: R2.1

commit 10e2976d18558cb6d110a0df740d413e40b05884
Author: Nischal Sheth <email address hidden>
Date: Mon May 18 11:07:04 2015 -0700

Improve error handling for static route config parsing

Do not assert when we encounter parse errors in prefixes,
nexthops and route targets.
Add tests to cover the above scenarios.

Change-Id: Ia0fb3404dafe734ef4ad6e13885d53766aa6d95b
Partial-Bug: 1456193

Reviewed: https://review.opencontrail.org/10516
Committed: http://github.org/Juniper/contrail-controller/commit/eb162919dbc221541b82d8d5dc7ea460ee2a1d5d
Submitter: Zuul
Branch: R2.20

commit eb162919dbc221541b82d8d5dc7ea460ee2a1d5d
Author: Nischal Sheth <email address hidden>
Date: Mon May 18 17:41:27 2015 -0700

Improve error handling for static route config parsing

Do not assert when we encounter parse errors in prefixes,
nexthops and route targets.
Add tests to cover the above scenarios.

Change-Id: Ibb7780bb367486a31eb4a57b1a61942c404e2342
Partial-Bug: 1456193

Reviewed: https://review.opencontrail.org/10628
Committed: http://github.org/Juniper/contrail-controller/commit/0e10174642f10e7bc2a8c1776303f622856fc18f
Submitter: Zuul
Branch: master

commit 0e10174642f10e7bc2a8c1776303f622856fc18f
Author: Nischal Sheth <email address hidden>
Date: Wed May 20 18:05:21 2015 -0700

Get rid of a few unnecessary asserts

Change-Id: I9e165d91c5c5485e908f44bee41688c52899c2d2
Partial-Bug: 1456193

Reviewed: https://review.opencontrail.org/10517
Committed: http://github.org/Juniper/contrail-controller/commit/ee68869d4bd0694085cd92478bdd9db88655123b
Submitter: Zuul
Branch: master

commit ee68869d4bd0694085cd92478bdd9db88655123b
Author: Nischal Sheth <email address hidden>
Date: Mon May 18 17:41:27 2015 -0700

Improve error handling for static route config parsing

Do not assert when we encounter parse errors in prefixes,
nexthops and route targets.
Add tests to cover the above scenarios.

Change-Id: Ibb7780bb367486a31eb4a57b1a61942c404e2342
Partial-Bug: 1456193

Reviewed: https://review.opencontrail.org/10631
Committed: http://github.org/Juniper/contrail-controller/commit/1b7e171b246a38154557c509ad1b42f96ea3a585
Submitter: Zuul
Branch: R2.1

commit 1b7e171b246a38154557c509ad1b42f96ea3a585
Author: Nischal Sheth <email address hidden>
Date: Wed May 20 18:05:21 2015 -0700

Get rid of a few unnecessary asserts

Change-Id: I9e165d91c5c5485e908f44bee41688c52899c2d2
Partial-Bug: 1456193

Reviewed: https://review.opencontrail.org/10633
Committed: http://github.org/Juniper/contrail-controller/commit/21e551fece825676d051ba8bd46fdf9deb900ee7
Submitter: Zuul
Branch: R2.0

commit 21e551fece825676d051ba8bd46fdf9deb900ee7
Author: Nischal Sheth <email address hidden>
Date: Wed May 20 18:05:21 2015 -0700

Get rid of a few unnecessary asserts

Change-Id: I9e165d91c5c5485e908f44bee41688c52899c2d2
Partial-Bug: 1456193

Reviewed: https://review.opencontrail.org/10561
Committed: http://github.org/Juniper/contrail-controller/commit/879f0b49e2f2559ca2bc5a3f8c62d9224197ad5a
Submitter: Zuul
Branch: R1.10

commit 879f0b49e2f2559ca2bc5a3f8c62d9224197ad5a
Author: Nischal Sheth <email address hidden>
Date: Mon May 18 11:07:04 2015 -0700

Improve error handling for static route config parsing

Do not assert when we encounter parse errors in prefixes,
nexthops and route targets.
Add tests to cover the above scenarios.

Change-Id: Ia0fb3404dafe734ef4ad6e13885d53766aa6d95b
Partial-Bug: 1456193

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers