[R2.20] vlan-port binding not seen in tor vtep db

[Vedamurthy Joshi]

R2.20 Ubuntu 14.04

On Amit Surana's setup, we had a scenario where on a TOR, 1 pif and lif were added with one Server in it

The TOR was later deleted and added multiple times.
It was seen that the vlan-port binding was not updated on the tor even though tor-agent introspect continued to show that binding is present

Prabhjot is already aware of the issue

root@TOR-2:~/openvswitch-2.3.1# vtep-ctl list-bindings TOR-2 ovstap1
root@TOR-2:~/openvswitch-2.3.1#

-------------------------------
output : http://10.87.129.74/Snh_OvsdbVlanPortBindingReq?session_remote_ip=&session_remote_port=
OvsdbVlanPortBindingResp

bindings
state physical_port physical_device logical_switch vlan
In sync(4)
ovstap1
TOR-2
ef083ed0-9550-46ff-80ff-c6a976bd9f88
0
more

-------------------------------

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9375
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9376
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9375
Committed: http://github.org/Juniper/contrail-controller/commit/46814398237fb80f8d386b23bf279cfdf94f1d6a
Submitter: Zuul
Branch: master

commit 46814398237fb80f8d386b23bf279cfdf94f1d6a
Author: Prabhjot Singh Sethi <email address hidden>
Date: Wed Apr 22 12:13:09 2015 +0530

Fix TOR agent Stale entry creation

Issue:
------
During session connect config listen and OVSDB info read
happens in parallel, in case if we receive an incomplete
config for Vlan port binding we create an entry and keep
it in defered state to wait for completion of info.
In the mean while if OVSDB read also gives the same info
while trying to create a stale entry we hit the assert

Fix:
----
we should not assert for failure in creation of stale entry
also we will connect/listen to OPER DB for config only
after complete of intial read, so that we should not fail
to create stale entries, while we had incomplete info in
config

Also adding fix for not creating vrf ovsdb stale entry for
OvsdbClientIdl::OVSDB_DEL operation

Added test-cases

Closes-Bug: 1441172
Closes-Bug: 1448857
Change-Id: Ie307f824ec21d268f7f90d4e6d2bfb7662401bdb

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9376
Committed: http://github.org/Juniper/contrail-controller/commit/d5e509a515c411eb0455c6168172a569035a87bb
Submitter: Zuul
Branch: R2.20

commit d5e509a515c411eb0455c6168172a569035a87bb
Author: Prabhjot Singh Sethi <email address hidden>
Date: Wed Apr 22 12:13:09 2015 +0530

Fix TOR agent Stale entry creation

Issue:
------
During session connect config listen and OVSDB info read
happens in parallel, in case if we receive an incomplete
config for Vlan port binding we create an entry and keep
it in defered state to wait for completion of info.
In the mean while if OVSDB read also gives the same info
while trying to create a stale entry we hit the assert

Fix:
----
we should not assert for failure in creation of stale entry
also we will connect/listen to OPER DB for config only
after complete of intial read, so that we should not fail
to create stale entries, while we had incomplete info in
config

Also adding fix for not creating vrf ovsdb stale entry for
OvsdbClientIdl::OVSDB_DEL operation

Added test-cases

Closes-Bug: 1441172
Closes-Bug: 1448857
(cherry picked from commit 46814398237fb80f8d386b23bf279cfdf94f1d6a)

Change-Id: I08a62d0b4308c40fcd640b803dcaed4e38328274