panic in github.com/juju/juju/provider/openstack.(*Environ).StartInstance.func2

[Junien F]

Hi,

jujud 2.4.5 controller just panic'ed with the following :

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x239cf2d]

goroutine 430087194 [running]:
github.com/juju/juju/provider/openstack.(*Environ).StartInstance.func2(0x37e11d600, 0xbebc200, 0x0, 0xc007d25820, 0xc00becadc0, 0x34, 0xc199525920, 0x24, 0xc219dd24e0, 0
x24, ...)
        /workspace/_build/src/github.com/juju/juju/provider/openstack/provider.go:1160 +0x22d
github.com/juju/juju/provider/openstack.(*Environ).StartInstance(0xc007446340, 0x37786e0, 0xc1753fd2f8, 0xc1e8959200, 0x24, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /workspace/_build/src/github.com/juju/juju/provider/openstack/provider.go:1185 +0xcfb
github.com/juju/juju/worker/provisioner.(*provisionerTask).startMachine(0xc13a3934a0, 0xc0a03f24e0, 0x0, 0x0, 0x0, 0xc09566b600, 0x1c)
        /workspace/_build/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:1072 +0x355
github.com/juju/juju/worker/provisioner.(*provisionerTask).startMachines.func1(0xc1c31b3bd0, 0xc13a3934a0, 0xc157f98b20, 0x1, 0x1, 0xc0a03f24e0, 0x0, 0x0, 0x0, 0x0)
        /workspace/_build/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:921 +0x8d
created by github.com/juju/juju/worker/provisioner.(*provisionerTask).startMachines
        /workspace/_build/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:919 +0x343

We had some control-plane issues with openstack at the time, API calls may have timed out, etc...

Thanks

[Anastasia (anastasia-macmood)]

The panic line is actually a log message - https://github.com/juju/juju/blob/2.4/provider/openstack/provider.go#L1160.

I'll add a guard to avoid it.

[Anastasia (anastasia-macmood)]

PR against 2.4: https://github.com/juju/juju/pull/9525

[Anastasia (anastasia-macmood)]

PR for 2.5: https://github.com/juju/juju/pull/9539