We incorrectly assume charms with name starting "juju-" are special

Bug #2037409 reported by Jack Shaw
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Triaged
Medium
Jack Shaw

Bug Description

In a few places in the juju codebase, we branch based on if the charm name starts with `juju-`. The justification being that these charms are a special case of "system charms".

https://github.com/juju/juju/blob/3.3/state/machine.go#L613-L615
https://github.com/juju/juju/blob/3.3/state/application.go#L2460-L2462

However, there is nothing stopping local charms starting with "juju-" and there are a number of charms in charmhub starting with "juju-" (e.g. juju-qa-test) which are not "system charms"

This is likely to cause problems in the future

Revision history for this message
Harry Pidcock (hpidcock) wrote :

In both places referenced these are dealing with juju- charms on a controller machine or an application in the controller model. It would be a simple fix by simply blocking "juju-" prefixed deploys onto the controller model at the facade level.

Changed in juju:
assignee: nobody → Jack Shaw (jack-shaw)
importance: Undecided → Medium
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.