network-get filters on loopback addresses

[Peter Jose De Sousa]

Hello,

Currently the jujud agent will discover /32 addresses from a manual machine but network-get will filter these addresses if they have a config type fo loopback.

Example:

juju spaces:

Name Space ID Subnets
alpha 0 <CIDRS...>
bgp x.x.x.x/32
                 y.y.y.y/32
                 u.u.u.u/32

unit/x in juju debug-env (magpie bound to bgp):

lo: x.x.x.x/32
network-get --ingress-address magpie

ERROR no network config found for binding "magpie"

This appears to be caused by this line in the juju network method ConvertToSpaceAddress: https://github.com/juju/juju/blob/develop/core/network/address.go#L880

as removing this line like shown in the diff to remove the ConfigLoopback check fixes this issue:

+++ b/core/network/address.go
@@ -918,7 +918,7 @@ func ConvertToSpaceAddress(addr SpaceAddressCandidate, lookup SubnetLookup) (Spa

        // If this is not a loopback device, attempt to
        // set the space ID based on the subnet.
- if addr.ConfigMethod() != ConfigLoopback && cidr != "" {
+ if cidr != "" {
                allMatching, err := subnets.GetByCIDR(cidr)
                if err != nil {

Im not sure if this is the correct change in the long run, but has the desired result,

Thank you,
Peter

[Peter Jose De Sousa (pjds)]

draft PR opened here: https://github.com/juju/juju/pull/15528

[Joseph Phillips (manadart)]

Commit above is included in:
https://github.com/juju/juju/pull/15530