audit.log defaults to including 'Pinger.ping'

[John A Meinel]

Audit log is meant to track user requests, with a default of
audit-log-exclude-methods ReadOnlyMethods

IOW, audit everything that is going on, but you don't need to record every time a user runs `juju status`.

However, looking at my local lxd controller's /var/log/juju/audit.log I see:
{"conversation":{"who":"admin","what":"juju ssh --debug 6","when":"2022-07-27T14:38:28Z","model-name":"default","model-uuid":"eb001ecd-2ba8-4681-8a58-b0776403b12f","conversation-id":"b690e9f313b8d7f3","connection-id":"99"}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":2,"when":"2022-07-27T14:38:28Z","facade":"SSHClient","method":"Proxy","version":3}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":2,"when":"2022-07-27T14:38:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":3,"when":"2022-07-27T14:38:28Z","facade":"SSHClient","method":"AllAddresses","version":3}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":3,"when":"2022-07-27T14:38:28Z","errors":[null]}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":4,"when":"2022-07-27T14:38:28Z","facade":"SSHClient","method":"PublicKeys","version":3}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":4,"when":"2022-07-27T14:38:28Z","errors":[null]}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":5,"when":"2022-07-27T14:38:28Z","facade":"SSHClient","method":"PublicKeys","version":3}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":5,"when":"2022-07-27T14:38:28Z","errors":[null]}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":6,"when":"2022-07-27T14:39:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":6,"when":"2022-07-27T14:39:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":7,"when":"2022-07-27T14:40:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":7,"when":"2022-07-27T14:40:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":8,"when":"2022-07-27T14:41:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":8,"when":"2022-07-27T14:41:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":9,"when":"2022-07-27T14:42:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":9,"when":"2022-07-27T14:42:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":10,"when":"2022-07-27T14:43:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":10,"when":"2022-07-27T14:43:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":11,"when":"2022-07-27T14:44:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":11,"when":"2022-07-27T14:44:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":12,"when":"2022-07-27T14:45:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":12,"when":"2022-07-27T14:45:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":13,"when":"2022-07-27T14:46:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":13,"when":"2022-07-27T14:46:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":14,"when":"2022-07-27T14:47:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":14,"when":"2022-07-27T14:47:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":15,"when":"2022-07-27T14:48:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":15,"when":"2022-07-27T14:48:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":16,"when":"2022-07-27T14:49:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":16,"when":"2022-07-27T14:49:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":17,"when":"2022-07-27T14:50:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":17,"when":"2022-07-27T14:50:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":18,"when":"2022-07-27T14:51:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":18,"when":"2022-07-27T14:51:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":19,"when":"2022-07-27T14:52:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":19,"when":"2022-07-27T14:52:28Z","errors":null}}
{"request":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":20,"when":"2022-07-27T14:53:28Z","facade":"Pinger","method":"Ping","version":1}}
{"errors":{"conversation-id":"b690e9f313b8d7f3","connection-id":"99","request-id":20,"when":"2022-07-27T14:53:28Z","errors":null}}

So it seems that for the duration of a `juju ssh` session (or some fashion of keeping alive the connection to the controller for the purposes of juju ssh), we record all of the API pings from tha client.
I believe we should suppress Pinger.Ping from audit logs by default as they are just noise.

[John A Meinel (jameinel)]

(The bug might also be that during the duration of `juju ssh` we are keeping a connection open to the Juju Controller that we don't really need, and we could really just close it once openssh has been spawned.)

[Canonical Juju QA Bot (juju-qa-bot)]

This Medium-priority bug has not been updated in 60 days, so we're marking it Low importance. If you believe this is incorrect, please update the importance.