change in default lxd profile

[John A Meinel]

I just set up lxd 3.22 on a new AWS instance, and ran through a normal configuration during lxd init.
After doing so, trying to do "juju bootstrap lxd" failed (with juju 2.7.4 from snap).

It failed with this message:
$ juju bootstrap lxd lxd --no-gui
ERROR profile "default": no network device found with nictype "bridged" or "macvlan"
        the following devices were checked: eth0

It seems that LXD has changed how they do networking. Specifically if you look at the default profile:
$ lxc profile show default
config: {}
description: Default LXD profile
devices:
  eth0:
    name: eth0
    network: lxdbr0
    type: nic
  root:
    path: /
    pool: default
    type: disk
name: default
used_by: []

Note that it is explicitly a 'device named eth0 of type nic (not bridged) but which is in a network'.
If you look at the default of the network you get:
~$ lxc network show lxdbr0
config:
  ipv4.address: 10.98.62.1/24
  ipv4.nat: "true"
  ipv6.address: none
description: ""
name: lxdbr0
type: bridge
used_by: []
managed: true
status: Created
locations:
- none

And *that* states that it is bridged.

Even more interesting, is that if you drop into edit the default profile:

### A profile consists of a set of configuration items followed by a set of
### devices.
###
### An example would look like:
### name: onenic
### config:
### raw.lxc: lxc.aa_profile=unconfined
### devices:
### eth0:
### nictype: bridged
### parent: lxdbr0
### type: nic
###
### Note that the name is shown but cannot be changed

config: {}
description: Default LXD profile
devices:
  eth0:
    name: eth0
    network: lxdbr0
    type: nic
  root:
    path: /
    pool: default
    type: disk
name: default
used_by: []

What I find very interesting is that their *example* shows having a nictype: bridged with a parent, but their default configuration is just a normal nic in a network which is bridged.

We should definitely support the new syntax for bridges.

[Joseph Phillips (manadart)]

2.7 https://github.com/juju/juju/pull/11333

[Joseph Phillips (manadart)]

Merge forward to edge: https://github.com/juju/juju/pull/11336

[Joseph Phillips (manadart)]

I messed up the fix by one letter. This properly addresses it:
https://github.com/juju/juju/pull/11404