Removal command output can be improved

Bug #1830935 reported by Peter Matulis on 2019-05-29
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
juju
Medium
Anastasia
2.6
Medium
Anastasia

Bug Description

The output to destroy-model and kill-controller and destroy-controller is often exaggerated, and frankly, unsightly. I propose that any repeated line be replaced by a single dot at the end of the line. That is, a dot gets appended for every line that would otherwise get printed.

For example, this `destroy-model` output:

Destroying model
Waiting on model to be removed, 1 application(s), 1 volume(s), 1 filesystems(s)...
Waiting on model to be removed, 1 application(s), 1 volume(s), 1 filesystems(s)...
Waiting on model to be removed, 1 application(s), 1 volume(s), 1 filesystems(s)...
Waiting on model to be removed, 1 application(s)...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Waiting on model to be removed...
Model destroyed.

would become:

Destroying model
Waiting on model to be removed, 1 application(s), 1 volume(s), 1 filesystems(s)..
Waiting on model to be removed, 1 application(s)
Waiting on model to be removed.....................
Model destroyed.

Alternative suggestion: implement a CLI spinner for each unique line.

n.b. The phrase "Waiting on model to be removed" should be "Waiting for model to be removed".

Anastasia (anastasia-macmood) wrote :

Thank you, @Peter Matulis,

I am in the area and will address as a drive-by :)

Changed in juju:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Anastasia (anastasia-macmood)
tags: added: usability
Tim McNamara (tim-clicks) wrote :

Exciting! This is a real win

Anastasia (anastasia-macmood) wrote :

kill-controller and destroy-controller is not actually that repetitive. I could not reproduce it and looking at the code, it will not be easy to improve.

I am keeping this report for the improvement of destroy-model output only. If you do encounter a case where you get a repetitive output for controller equivalent, please file a separate bug and include steps to reproduce :)

Anastasia (anastasia-macmood) wrote :
Changed in juju:
milestone: none → 2.7-beta1
Changed in juju:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers