MoreImportantError does not describe what happens errors have equal importance

[Tim McNamara]

cmd/jujud/util/util.go (https://github.com/juju/juju/blob/f747191ed950a2b989e42916de5f9b333889ded7/cmd/jujud/util/util.go#L90) does not describe what should happen in the case of a draw. It currently returns the second argument, in essence giving err1 more weight over err0.

    // MoreImportantError returns the most important error
    func MoreImportantError(err0, err1 error) error {
     if importance(err0) > importance(err1) {
      return err0
     }
     return err1
    }

This behaviour may be intentional, but should be made explicit in the function's documentation.

[Canonical Juju QA Bot (juju-qa-bot)]

This bug has not been updated in 2 years, so we're marking it Low importance. If you believe this is incorrect, please update the importance.