maas aborted transaction trying to update link layer device

[Christian Muirhead]

In a model we were seeing two link layer devices with the same provider id (the example we were seeing was a nic and a bridge on that nic). In that situation, when we try to call Machine.SetLinkLayerDevices Machine.updateLinkLayerDeviceOps produces a transaction with an assertion that the providerIDs record doesn't exist - this fails because it's already associated with the other device.

Reading SetLinkLayerDevices it's doing some uniqueness checking against the provider ids already in the db, but it doesn't look like it's checking whether the provider IDs on the link layer devices passed in are unique. We need to decide how to handle that case.

This was on MAAS 1.9, not sure whether it's specific to 1.9 or not.

[Joseph Phillips (manadart)]

Is there any more detail we can get around steps to reproduce?

Series in use, what NICs are on the host?

[Christian Muirhead (2-xtian)]

Sorry, here's some more info from Xav Paice - this is from a client site, so I'll leave it on pastebin.canonical.com rather than copying it in here.

The transaction that was failing:
https://pastebin.canonical.com/p/R4srS6WrRJ/

Network info for the machine:
https://pastebin.canonical.com/p/Vd5hSyDN2H/

MAAS info:
https://pastebin.canonical.com/p/Ys3hdX8VzP/

[Anastasia (anastasia-macmood)]

Removing from a milestone as this work will not be done in 2.5 series.

[Joseph Phillips (manadart)]

Proposed: https://github.com/juju/juju/pull/10878