more verbose error logging around errors from workers

[Junien F]

Hi,

On a 2.4.3 controller, we have the following error logs :

2018-10-23 14:17:08 ERROR juju.worker.dependency engine.go:587 "compute-provisioner" manifold worker returned unexpected error:
The provided credentials could not be validated and
may not be authorized to carry out the request.
Ensure that your account is authorized to use the Amazon EC2 service and
that you are using the correct access keys.
These keys are obtained via the "Security Credentials"
page in the AWS console.
: AWS was not able to validate the provided access credentials (AuthFailure)

and also

2018-10-23 14:17:08 ERROR juju.worker.dependency engine.go:587 "firewaller" manifold worker returned unexpected error: cannot respond to units changes for "machine-2":
The provided credentials could not be validated and
may not be authorized to carry out the request.
Ensure that your account is authorized to use the Amazon EC2 service and
that you are using the correct access keys.
These keys are obtained via the "Security Credentials"
page in the AWS console.
: AWS was not able to validate the provided access credentials (AuthFailure)

Could we please get more details about the model generating these errors ?

Thanks !

[Anastasia (anastasia-macmood)]

This errors come from the cloud calls made by a dependency engine.

By the time, we get this error, we are already in the cloud and it's not possible to determine what model made a call. What we can do is to ensure that any error reported via dependency agent *knows* the model. We can do that by keeping track of model uuids in worker manifest.

I have briefly mentioned the idea to the team and will start investigating solution implementation. Thank you for suggestion!

[Tim Penhey (thumper)]

While the messages aren't prefixed, they are now split out into different files and log collections.

See https://discourse.jujucharms.com/t/upcoming-2-7-model-logs-for-controller-workers/2220

[Junien F (axino)]

This looks great, thanks !