juju deploy should do some sanity checking of charms

Bug #1779337 reported by James Troup on 2018-06-29
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
juju
High
Anastasia
2.3
High
Anastasia
2.4
High
Anastasia

Bug Description

If you try to deploy an unbuilt reactive charm, juju deploy won't stop you or warn you that anything is wrong.

This is a mistake I think everyone working with reactive charms makes at least once and it seems like it'd be easy for Juju to help the user out. For example, if it's asked to deploy a charm with no hooks directory at all, it should probably say something about that in the logs.

Ian Booth (wallyworld) on 2018-06-29
Changed in juju:
milestone: none → 2.4.1
status: New → Triaged
importance: Undecided → High
Haw Loeung (hloeung) wrote :

There's also a related bug filed against the charm store to reject charms pushed without hooks - https://github.com/juju/charmstore/issues/769. I'm not saying that we shouldn't also update juju to detect this and would be nice to have both.

Tim Penhey (thumper) on 2018-07-01
tags: added: deploy papercut usability
Changed in juju:
milestone: 2.4.1 → 2.4.2
Changed in juju:
assignee: nobody → Anastasia (anastasia-macmood)
Changed in juju:
assignee: Anastasia (anastasia-macmood) → nobody
Changed in juju:
milestone: 2.4.2 → 2.5-beta1
Anastasia (anastasia-macmood) wrote :

...and here is the actual PR against 2.3: https://github.com/juju/juju/pull/9035 :)

Anastasia (anastasia-macmood) wrote :
Changed in juju:
status: Triaged → In Progress
assignee: nobody → Anastasia (anastasia-macmood)
Anastasia (anastasia-macmood) wrote :

PR against develop (heading into 2.5): https://github.com/juju/juju/pull/9038

Changed in juju:
status: In Progress → Fix Committed
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.