Backup commands are inconsistent when referring to remote backups

[Peter Matulis]

The following backup commands do not require the use of the '--id=' option when specifying a remotely-stored (on the controller) backup archive:

download-backup
remove-backup
show-backup

However, strangely, this command does:

restore-backup

[John A Meinel (jameinel)]

FWIW that is because download/show/remove *must* be talking about the
remote backup, while "restore-backup" might be talking about a local one or
a remote one.
If we move to not storing backups on the controllers by default, then none
of download/remove/show become useful because there is nothing for them to
operate on.

On Wed, May 16, 2018 at 1:14 AM, Peter Matulis <email address hidden>
wrote:

> Public bug reported:
>
> The following backup commands do not require the use of the '--id='
> option when specifying a remotely-stored (on the controller) backup
> archive:
>
> download-backup
> remove-backup
> show-backup
>
> However, strangely, this command does:
>
> restore-backup
>
> ** Affects: juju
> Importance: Undecided
> Status: New
>
>
> ** Tags: backup-restore docteam
>
> ** Description changed:
>
> - The following backup commands do not require the use of the '--id=='
> + The following backup commands do not require the use of the '--id='
> option when specifying a remotely-stored (on the controller) backup
> archive:
>
> download-backup
> remove-backup
> show-backup
>
> However, strangely, this command does:
>
> restore-backup
>
> --
> You received this bug notification because you are subscribed to juju.
> Matching subscriptions: juju bugs
> https://bugs.launchpad.net/bugs/1771433
>
> Title:
> Backup commands are inconsistent when referring to remote backups
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju/+bug/1771433/+subscriptions
>

[Peter Matulis (petermatulis)]

But '--file' is used to denote a local backup.

[Eric Claude Jones (ecjones)]

Hi Peter,

Just out of curiosity, what would the `restore-backup` command look like if it were more consistent with the other commands (i.e. didn't have the `--id` option)?

juju remove-backup [options] <ID>

Where ID is interpreted as a filepath if the --file option is present, maybe? Just curios.

[Peter Matulis (petermatulis)]

Eric, yes, just as you described.

[Richard Harding (rharding)]

Are we not storing backups by default now? I now I saw that we were adding code to clean old backups but you'd still be keeping one. Do we have notes on what the plan is here?

[Peter Matulis (petermatulis)]

Also, I feel like the 'file' option should also be consistent between `create-backup` and `restore-backup`. Currently, there is '--filename' and '--file', respectively. I favour the latter (--file). Either that or use very different names like '--output' and '--input'.

[Canonical Juju QA Bot (juju-qa-bot)]

This bug has not been updated in 2 years, so we're marking it Low importance. If you believe this is incorrect, please update the importance.